[PATCH] power/amd_uncore: detect esmi lib64 using pkgconfig

[PATCH] power/amd_uncore: detect esmi lib64 using pkgconfig

[Sivaprasad Tummala]

Replace manual detection of e_smi_lib64 library from find_library() with
dependency() via pkg-config in meson.

Meson find_library() API may select incompatible libraries,
requiring additional checks. Using pkg-config avoids this
by providing correct build flags via .pc files.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 drivers/power/amd_uncore/meson.build | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/power/amd_uncore/meson.build b/drivers/power/amd_uncore/meson.build
index cab260b64e..378eb72e50 100644
--- a/drivers/power/amd_uncore/meson.build
+++ b/drivers/power/amd_uncore/meson.build
@@ -7,14 +7,12 @@ if not is_linux
     subdir_done()
 endif
 
-ESMI_header = '#include<e_smi/e_smi.h>'
-lib = cc.find_library('e_smi64', required: false)
-if not lib.found() or not cc.links(min_c_code, dependencies: lib)
+dep = dependency('e_smi_lib64', required: false, method: 'pkg-config')
+if not dep.found()
     build = false
-    reason = 'missing dependency, "libe_smi"'
-else
-    ext_deps += lib
+    reason = 'missing dependency, "e_smi_lib64"'
+    subdir_done()
 endif
-
 sources = files('amd_uncore.c')
+ext_deps += dep
 deps += ['power']
-- 
2.43.0

Re: [PATCH] power/amd_uncore: detect esmi lib64 using pkgconfig

[Stephen Hemminger]

On Tue, 31 Mar 2026 04:09:58 +0000
Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote:

> Replace manual detection of e_smi_lib64 library from find_library() with
> dependency() via pkg-config in meson.
> 
> Meson find_library() API may select incompatible libraries,
> requiring additional checks. Using pkg-config avoids this
> by providing correct build flags via .pc files.
> 
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>

Looks much better. I know Fedora has the library not sure about RHEL, Ubuntu, ...
but they will get there.

The documentation needs updating and a release note (for 26.07)
would make it easier for the user.