From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 4/4] app/test_compress: remove unnecessary null check
Date: Wed, 1 Apr 2026 09:40:25 -0700 [thread overview]
Message-ID: <20260401164108.201404-5-stephen@networkplumber.org> (raw)
In-Reply-To: <20260401164108.201404-1-stephen@networkplumber.org>
No need to check for null before calling free.
Found by coccinelle script null_free.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test-compress-perf/main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c
index c9ead02cb4..bc2b185da4 100644
--- a/app/test-compress-perf/main.c
+++ b/app/test-compress-perf/main.c
@@ -392,15 +392,13 @@ comp_perf_dump_dictionary_data(struct comp_test_data *td)
if (fread(data, data_to_read, 1, f) != 1) {
RTE_LOG(ERR, USER1, "Input file could not be read\n");
- if (td->dictionary_data)
- rte_free(td->dictionary_data);
+ rte_free(td->dictionary_data);
goto end;
}
if (fseek(f, 0, SEEK_SET) != 0) {
RTE_LOG(ERR, USER1,
"Size of input could not be calculated\n");
- if (td->dictionary_data)
- rte_free(td->dictionary_data);
+ rte_free(td->dictionary_data);
goto end;
}
remaining_data -= data_to_read;
--
2.53.0
prev parent reply other threads:[~2026-04-01 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 16:40 [PATCH 0/4] remove useless null checks before free Stephen Hemminger
2026-04-01 16:40 ` [PATCH 1/4] net/ice: remove unnecessary null check Stephen Hemminger
2026-04-01 16:44 ` Bruce Richardson
2026-04-01 16:40 ` [PATCH 2/4] net/bnxt: " Stephen Hemminger
2026-04-01 16:40 ` [PATCH 3/4] net/zxdh: " Stephen Hemminger
2026-04-01 16:40 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401164108.201404-5-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox