public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: [RFC 4/4] devtools: demote tag ordering to warning
Date: Thu,  2 Apr 2026 09:16:09 -0700	[thread overview]
Message-ID: <20260402161719.82570-5-stephen@networkplumber.org> (raw)
In-Reply-To: <20260402161719.82570-1-stephen@networkplumber.org>

The Linux kernel does not enforce a strict tag ordering via tooling.
Ordering is a convention, enforced socially by maintainers rather
than by checkpatch.pl.  The b4 tool has a configurable trailer-order
preference, but it is not mandatory.

Demote the tag ordering check from an error (which sets failure=true
and causes a non-zero exit) to a warning (printed but does not
affect the exit code).  This avoids rejecting patches that are
otherwise correct but happen to have Reviewed-by before Acked-by
or similar minor ordering differences.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 devtools/check-git-log.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 94cf68b926..5b621f5c8d 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -266,8 +266,7 @@ bad=$(for commit in $commits; do
 			chronological = 1;
 	 }'
 done)
-[ -z "$bad" ] || { printf "Wrong tag order: \n$bad\n"\
-	&& failure=true;}
+[ -z "$bad" ] || printf "WARNING: non-preferred tag order: \n$bad\n"
 
 # check required tag
 bad=$(for commit in $commits; do
-- 
2.53.0


      parent reply	other threads:[~2026-04-02 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 16:16 [PATCH 0/4] devtools: align trailer checks with kernel convention Stephen Hemminger
2026-04-02 16:16 ` [RFC 3/4] devtools: remove blank line requirement between trailers Stephen Hemminger
2026-04-02 16:16 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260402161719.82570-5-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox