From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD1BD6AAFE for ; Thu, 2 Apr 2026 19:46:46 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B5BF40E39; Thu, 2 Apr 2026 21:46:28 +0200 (CEST) Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) by mails.dpdk.org (Postfix) with ESMTP id 43A2440E0F for ; Thu, 2 Apr 2026 21:46:25 +0200 (CEST) Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2c7d8bbad06so3011723eec.1 for ; Thu, 02 Apr 2026 12:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1775159184; x=1775763984; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J9u351Hm+DspJDffPbnt4d8EeaqziYPgBU232GfW/Po=; b=zzBekEQhvrx/WuUgwEyTC0fe74gS7aM2kJ4w+L1fkVpb4+V5c4U4mXcyWiByGjRy6s ArwkgD+UShQpId3O6T00FDR3JqbBk/hlYhV+lTz7yCqWwQrYEOnZDml3+ctW0vcNnxAP MxHBX11Kua2VevOgzsGOVbft93d2hvb+TNBmZLITeGpLXU6hLwG4j1+LDEtloEkQzOhf G1LypN8N0l9w5sT1rwZ5svylRRpmf8YrK9R8jFqwkinWF3dRmJTxZgvP7Uvk9mY1FkYB aAyZS4MWq9uI2I1nrjjz1a55qTg+u6GKp+umamKY19gTM3qGy/ZDhd8v4HcxGaSWk9ts 72Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775159184; x=1775763984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J9u351Hm+DspJDffPbnt4d8EeaqziYPgBU232GfW/Po=; b=q89mSyRR7Lx8tqLKZ1Bx9ERnxPBpzRFmQpQOGECkVLxvYcBIHop8/jh5ZphcNb2cCC 2dfZ921ebZ+wBwNRMsD6ZdAV7R7/Ggkbk0Yy2agS04Cu+iQ0r3uTlST3nxRuyC9Cyt51 tLn2DgLCrOvNRRogPqsokss+n9cPy/qHTmmbUowMeBvxGg5KFrWBOnRIszIK/LLM7KpZ qBJzQlMZaDdDSzgytAxL7zXQXWMkY5M9oOXs6yFI/1YMZF3JdCqKCfn+owyjHulKCt82 u8ZRB2adeldSX1z/fWnWfNMAaGyfRUVhR4VitbqhiQLGpwPyY/ev4VOfcqMI1VvQsv1r Gafg== X-Gm-Message-State: AOJu0YyNvmte2JZsnUG8O4ZpDk/YqIlNfkPC98m2FboAe7pL4m6kssaS MEiTvCmPkYVKk78+hMy91gwmju2ZHMxqLWhjw2ap6DyF/wXBQ8syKi+xfMwypj0+tQvHtJgkrkL ZNHdp X-Gm-Gg: AeBDieu3bft3EpwxnJvBKe3m/UJTf43pnVCxrQME5ly4j4kllEMXE2YVAsL9eXkbP3R HNYqhMfsvaLV6g4P+0n5yGTunZrHzFlGSDjzWpxJqzVi2ovfstfzvNSEMbTkp9SVRjrw8z4x2y2 90oYOSritoYeIsVuf2/Vt3wDVvxSJdL+YF87qEOq4IfXf4RtQ6aEEDS5qzHJHd3kS3jdnr24o42 +pEmtwDsLsnV1ECMOY+vYkL1pbC7hDRFwUO08rSmgx0DfgQqPankxuFnaf++Pb1shH+sIpKZdsV TZ04CUG6M0iDqinkDrmQT9ruoZEbTmOs4qEPdJoyOx4Jf6mxFEqvG+Y8C8mxsOhX7AYWqNVo5nQ LezYjTQAymPV1PBpkrE4U5eBvdcrv49Sd5mxo0Bi43KZZs9KXZncClHu7ZWUAmwlyZncNmnfgQ7 dhLoyt2YvmRFXnljdcOB8ll95gauVEUrtZB5m2HR76RB8= X-Received: by 2002:a05:7301:4090:b0:2ca:e4f2:31ff with SMTP id 5a478bee46e88-2cbf99ec0b9mr272185eec.6.1775159184141; Thu, 02 Apr 2026 12:46:24 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca78df5ec7sm3164279eec.3.2026.04.02.12.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 12:46:23 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Aaron Conole Subject: [PATCH v13 3/6] devtools: add compare-reviews.sh for multi-provider analysis Date: Thu, 2 Apr 2026 12:44:33 -0700 Message-ID: <20260402194618.134002-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260402194618.134002-1-stephen@networkplumber.org> References: <20260126184205.104629-1-stephen@networkplumber.org> <20260402194618.134002-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add script to run patch reviews across multiple AI providers for comparison purposes. The script automatically detects which providers have API keys configured and runs analyze-patch.py for each one. This allows users to compare review quality and feedback across different AI models. Features: - Auto-detects available providers based on environment variables - Optional provider selection via -p/--providers option - Saves individual reviews to separate files with -o/--output - Verbose mode passes through to underlying analyze-patch.py Usage: ./devtools/compare-reviews.sh my-patch.patch ./devtools/compare-reviews.sh -p anthropic,xai my-patch.patch ./devtools/compare-reviews.sh -o ./reviews my-patch.patch Output files are named -.txt when using the output directory option. Signed-off-by: Stephen Hemminger --- devtools/compare-reviews.sh | 263 ++++++++++++++++++++++++++++++++++++ 1 file changed, 263 insertions(+) create mode 100755 devtools/compare-reviews.sh diff --git a/devtools/compare-reviews.sh b/devtools/compare-reviews.sh new file mode 100755 index 0000000000..b4813cb6a7 --- /dev/null +++ b/devtools/compare-reviews.sh @@ -0,0 +1,263 @@ +#!/bin/bash +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2026 Stephen Hemminger + +# Compare DPDK patch reviews across multiple AI providers +# Runs analyze-patch.py with each available provider + +set -o pipefail + +SCRIPT_DIR="$(dirname "$(readlink -f "$0")")" +ANALYZE_SCRIPT="${SCRIPT_DIR}/analyze-patch.py" +AGENTS_FILE="AGENTS.md" +OUTPUT_DIR="" +PROVIDERS="" +FORMAT="text" +VERBOSE="" +EXTRA_ARGS=() + +usage() { + cat < + +Compare DPDK patch reviews across multiple AI providers. + +Options: + -a, --agents FILE Path to AGENTS.md file (default: AGENTS.md) + -o, --output DIR Save individual reviews to directory + -p, --providers LIST Comma-separated list of providers to use + (default: all providers with API keys set) + -f, --format FORMAT Output format: text, markdown, html, json + (default: text) + -t, --tokens N Max tokens for response + -D, --date DATE Review date context (YYYY-MM-DD) + -r, --release VERSION Target DPDK release (e.g., 24.11, 23.11-lts) + --split-patches Split mbox into individual patches + --patch-range N-M Review only patches N through M + --large-file MODE Handle large files: error, truncate, chunk, + commits-only, summary + --max-tokens N Max input tokens + -v, --verbose Show verbose output from each provider + -h, --help Show this help message + +Environment Variables: + Set API keys for providers you want to use: + ANTHROPIC_API_KEY, OPENAI_API_KEY, XAI_API_KEY, GOOGLE_API_KEY + +Examples: + $(basename "$0") my-patch.patch + $(basename "$0") -p anthropic,openai my-patch.patch + $(basename "$0") -o ./reviews -f markdown my-patch.patch + $(basename "$0") -r 24.11 --split-patches series.mbox +EOF + exit "${1:-0}" +} + +error() { + echo "Error: $1" >&2 + exit 1 +} + +# Check which providers have API keys configured +get_available_providers() { + local available="" + + [[ -n "$ANTHROPIC_API_KEY" ]] && available="${available}anthropic," + [[ -n "$OPENAI_API_KEY" ]] && available="${available}openai," + [[ -n "$XAI_API_KEY" ]] && available="${available}xai," + [[ -n "$GOOGLE_API_KEY" ]] && available="${available}google," + + # Remove trailing comma + echo "${available%,}" +} + +# Get file extension for format +get_extension() { + case "$1" in + text) echo "txt" ;; + markdown) echo "md" ;; + html) echo "html" ;; + json) echo "json" ;; + *) echo "txt" ;; + esac +} + +# Parse command line options +while [[ $# -gt 0 ]]; do + case "$1" in + -a|--agents) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + AGENTS_FILE="$2" + shift 2 + ;; + -o|--output) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + OUTPUT_DIR="$2" + shift 2 + ;; + -p|--providers) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + PROVIDERS="$2" + shift 2 + ;; + -f|--format) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + FORMAT="$2" + shift 2 + ;; + -t|--tokens) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + EXTRA_ARGS+=("-t" "$2") + shift 2 + ;; + -D|--date) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + EXTRA_ARGS+=("-D" "$2") + shift 2 + ;; + -r|--release) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + EXTRA_ARGS+=("-r" "$2") + shift 2 + ;; + --split-patches) + EXTRA_ARGS+=("--split-patches") + shift + ;; + --patch-range) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + EXTRA_ARGS+=("--patch-range" "$2") + shift 2 + ;; + --large-file) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + EXTRA_ARGS+=("--large-file" "$2") + shift 2 + ;; + --large-file=*) + EXTRA_ARGS+=("$1") + shift + ;; + --max-tokens) + [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument" + EXTRA_ARGS+=("--max-tokens" "$2") + shift 2 + ;; + -v|--verbose) + VERBOSE="-v" + shift + ;; + -h|--help) + usage 0 + ;; + -*) + error "Unknown option: $1" + ;; + *) + break + ;; + esac +done + +# Check for required arguments +if [[ $# -lt 1 ]]; then + echo "Error: No patch file specified" >&2 + usage 1 +fi + +PATCH_FILE="$1" + +if [[ ! -f "$PATCH_FILE" ]]; then + error "Patch file not found: $PATCH_FILE" +fi + +if [[ ! -f "$ANALYZE_SCRIPT" ]]; then + error "analyze-patch.py not found: $ANALYZE_SCRIPT" +fi + +if [[ ! -f "$AGENTS_FILE" ]]; then + error "AGENTS.md not found: $AGENTS_FILE" +fi + +# Validate format +case "$FORMAT" in + text|markdown|html|json) ;; + *) error "Invalid format: $FORMAT (must be text, markdown, html, or json)" ;; +esac + +# Get providers to use +if [[ -z "$PROVIDERS" ]]; then + PROVIDERS=$(get_available_providers) +fi + +if [[ -z "$PROVIDERS" ]]; then + error "No API keys configured. Set at least one of: "\ +"ANTHROPIC_API_KEY, OPENAI_API_KEY, XAI_API_KEY, GOOGLE_API_KEY" +fi + +# Create output directory if specified +if [[ -n "$OUTPUT_DIR" ]]; then + mkdir -p "$OUTPUT_DIR" +fi + +PATCH_BASENAME=$(basename "$PATCH_FILE") +PATCH_STEM="${PATCH_BASENAME%.*}" +EXT=$(get_extension "$FORMAT") + +echo "Reviewing patch: $PATCH_BASENAME" +echo "Providers: $PROVIDERS" +echo "Format: $FORMAT" +echo "========================================" +echo "" + +# Run review for each provider, continue on failure +IFS=',' read -ra PROVIDER_LIST <<< "$PROVIDERS" +failures=0 +for provider in "${PROVIDER_LIST[@]}"; do + echo ">>> Running review with: $provider" + echo "" + + if [[ -n "$OUTPUT_DIR" ]]; then + OUTPUT_FILE="${OUTPUT_DIR}/${PATCH_STEM}-${provider}.${EXT}" + if python3 "$ANALYZE_SCRIPT" \ + -p "$provider" \ + -a "$AGENTS_FILE" \ + -f "$FORMAT" \ + ${VERBOSE:+"$VERBOSE"} \ + "${EXTRA_ARGS[@]}" \ + "$PATCH_FILE" | tee "$OUTPUT_FILE"; then + echo "" + echo "Saved to: $OUTPUT_FILE" + else + echo "FAILED: $provider review failed" >&2 + rm -f "$OUTPUT_FILE" + ((failures++)) || true + fi + else + if ! python3 "$ANALYZE_SCRIPT" \ + -p "$provider" \ + -a "$AGENTS_FILE" \ + -f "$FORMAT" \ + ${VERBOSE:+"$VERBOSE"} \ + "${EXTRA_ARGS[@]}" \ + "$PATCH_FILE"; then + echo "FAILED: $provider review failed" >&2 + ((failures++)) || true + fi + fi + + echo "" + echo "========================================" + echo "" +done + +echo "Review comparison complete." + +if [[ -n "$OUTPUT_DIR" ]]; then + echo "All reviews saved to: $OUTPUT_DIR" +fi + +if [[ $failures -gt 0 ]]; then + echo "$failures provider(s) failed." >&2 + exit 1 +fi -- 2.53.0