public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	Kevin Traynor <ktraynor@redhat.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Maxime Leroy <maxime@leroys.fr>,
	Sachin Saxena <sachin.saxena@nxp.com>
Subject: [PATCH v3 3/7] drivers/bus: require probe function for NXP drivers
Date: Tue,  7 Apr 2026 13:52:06 +0200	[thread overview]
Message-ID: <20260407115211.1903623-4-david.marchand@redhat.com> (raw)
In-Reply-To: <20260407115211.1903623-1-david.marchand@redhat.com>

Rather than silently ignore an invalid driver, enforce every registered
driver has a probe callback.

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Tested-by: Maxime Leroy <maxime@leroys.fr>
---
 drivers/bus/dpaa/dpaa_bus.c   | 6 +++---
 drivers/bus/fslmc/fslmc_bus.c | 7 +------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index d9830b68ca..5e0f32bfe8 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -614,6 +614,7 @@ void
 rte_dpaa_driver_register(struct rte_dpaa_driver *driver)
 {
 	RTE_VERIFY(driver);
+	RTE_VERIFY(driver->probe != NULL);
 
 	BUS_INIT_FUNC_TRACE();
 
@@ -808,9 +809,8 @@ rte_dpaa_bus_probe(void)
 			if (rte_dev_is_probed(&dev->device))
 				continue;
 
-			if (!drv->probe ||
-			    (dev->device.devargs &&
-			     dev->device.devargs->policy == RTE_DEV_BLOCKED))
+			if (dev->device.devargs &&
+			    dev->device.devargs->policy == RTE_DEV_BLOCKED)
 				continue;
 
 			if (probe_all ||
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index d058441a3f..20b08639b7 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -469,9 +469,6 @@ rte_fslmc_probe(void)
 			if (ret)
 				continue;
 
-			if (!drv->probe)
-				continue;
-
 			if (rte_dev_is_probed(&dev->device))
 				continue;
 
@@ -538,6 +535,7 @@ void
 rte_fslmc_driver_register(struct rte_dpaa2_driver *driver)
 {
 	RTE_VERIFY(driver);
+	RTE_VERIFY(driver->probe != NULL);
 
 	TAILQ_INSERT_TAIL(&rte_fslmc_bus.driver_list, driver, next);
 }
@@ -605,9 +603,6 @@ fslmc_bus_plug(struct rte_device *rte_dev)
 		if (ret)
 			continue;
 
-		if (!drv->probe)
-			continue;
-
 		if (rte_dev_is_probed(&dev->device))
 			continue;
 
-- 
2.53.0


  parent reply	other threads:[~2026-04-07 11:52 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 10:52 [PATCH 0/8] Rework device probing David Marchand
2026-03-23 10:52 ` [PATCH 1/8] devtools: check packet forwarding in null test David Marchand
2026-03-23 10:52 ` [PATCH 2/8] bus/fslmc: fix bus cleanup David Marchand
2026-03-23 16:59   ` Kevin Traynor
2026-03-26  8:22     ` David Marchand
2026-03-26  8:49       ` Kevin Traynor
2026-03-24  5:15   ` Hemant Agrawal
2026-03-24  5:15   ` Hemant Agrawal
2026-03-23 10:52 ` [PATCH 3/8] drivers/bus: require probe function for NXP drivers David Marchand
2026-03-23 16:59   ` Kevin Traynor
2026-03-24  5:15   ` Hemant Agrawal
2026-03-23 10:52 ` [PATCH 4/8] drivers: cleanup devargs lookup in bus scan David Marchand
2026-03-24  5:16   ` Hemant Agrawal
2026-03-24 14:13   ` Kevin Traynor
2026-03-24 16:10   ` Stephen Hemminger
2026-03-23 10:52 ` [PATCH 5/8] bus: factorize devargs lookup David Marchand
2026-03-24 14:16   ` Kevin Traynor
2026-03-24 16:11   ` Stephen Hemminger
2026-03-23 10:53 ` [PATCH 6/8] bus: factorize device selection David Marchand
2026-03-24 14:15   ` Kevin Traynor
2026-03-26  8:48     ` David Marchand
2026-03-24 16:12   ` Stephen Hemminger
2026-03-23 10:53 ` [PATCH 7/8] bus: remove per bus scan mode David Marchand
2026-03-24 16:02   ` Kevin Traynor
2026-03-24 16:27     ` Kevin Traynor
2026-03-26  8:54     ` David Marchand
2026-03-23 10:53 ` [PATCH 8/8] eal: configure initial device probing David Marchand
2026-03-25 10:57   ` Kevin Traynor
2026-03-24  5:17 ` [PATCH 0/8] Rework " Hemant Agrawal
2026-03-25 15:22 ` Maxime Leroy
2026-03-26 10:24 ` [PATCH v2 0/7] " David Marchand
2026-03-26 10:24   ` [PATCH v2 1/7] devtools: check packet forwarding in null test David Marchand
2026-03-26 10:24   ` [PATCH v2 2/7] bus/fslmc: fix bus cleanup David Marchand
2026-03-26 11:50     ` Kevin Traynor
2026-03-26 10:24   ` [PATCH v2 3/7] drivers/bus: require probe function for NXP drivers David Marchand
2026-03-26 10:24   ` [PATCH v2 4/7] drivers: cleanup devargs lookup in bus scan David Marchand
2026-03-28  3:13     ` fengchengwen
2026-03-26 10:24   ` [PATCH v2 5/7] bus: factorize devargs lookup David Marchand
2026-03-26 11:51     ` Kevin Traynor
2026-03-28  3:33     ` fengchengwen
2026-04-03 14:22       ` David Marchand
2026-03-26 10:24   ` [PATCH v2 6/7] bus: factorize device selection David Marchand
2026-03-26 11:52     ` Kevin Traynor
2026-03-28  3:38     ` fengchengwen
2026-03-26 10:24   ` [PATCH v2 7/7] eal: configure initial device probing David Marchand
2026-03-28  4:00     ` fengchengwen
2026-04-03 14:25       ` David Marchand
2026-04-07 11:52 ` [PATCH v3 0/7] Rework " David Marchand
2026-04-07 11:52   ` [PATCH v3 1/7] devtools: check packet forwarding in null test David Marchand
2026-04-07 11:52   ` [PATCH v3 2/7] bus/fslmc: fix bus cleanup David Marchand
2026-04-07 11:52   ` David Marchand [this message]
2026-04-07 11:52   ` [PATCH v3 4/7] drivers/bus: cleanup devargs lookup in scan David Marchand
2026-04-07 11:52   ` [PATCH v3 5/7] bus: factorize devargs lookup David Marchand
2026-04-08  1:18     ` fengchengwen
2026-04-07 11:52   ` [PATCH v3 6/7] bus: factorize device selection David Marchand
2026-04-07 11:52   ` [PATCH v3 7/7] eal: configure initial device probing David Marchand
2026-04-08  1:44     ` fengchengwen
2026-04-07 11:58   ` [PATCH v3 0/7] Rework " David Marchand
2026-04-07 15:12   ` Stephen Hemminger
2026-04-10 14:34   ` Morten Brørup
2026-04-10 15:16     ` Kevin Traynor
2026-04-10 17:37     ` Stephen Hemminger
2026-04-10 21:13       ` [EXTERNAL] " Long Li
2026-04-10 22:50         ` Stephen Hemminger
2026-04-11  7:30         ` Morten Brørup
2026-04-11 10:10     ` David Marchand
2026-04-11 10:23       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407115211.1903623-4-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=ktraynor@redhat.com \
    --cc=maxime@leroys.fr \
    --cc=sachin.saxena@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox