* [PATCH] net/ixgbe: shrink size of context index
@ 2026-04-08 15:48 Bruce Richardson
2026-04-09 12:18 ` Burakov, Anatoly
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2026-04-08 15:48 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
The ixgbe driver only supports two contexts, so using uint32_t for the
context index is excessive. Reducing this to uint8_t shrinks the ixgbe
part of the union from 32 bytes to 24. Although it does not in itself
shrink the space for the whole struct, it is worth doing as ixgbe is the
second-largest block in the union, so may become relevant if other
rework shrinks the idpf-specific block.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/intel/common/tx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
index f2123f069c..8cb281aa20 100644
--- a/drivers/net/intel/common/tx.h
+++ b/drivers/net/intel/common/tx.h
@@ -200,7 +200,7 @@ struct ci_tx_queue {
struct { /* ixgbe specific values */
const struct ixgbe_txq_ops *ops;
struct ixgbe_advctx_info *ctx_cache;
- uint32_t ctx_curr;
+ uint8_t ctx_curr;
uint8_t pthresh; /**< Prefetch threshold register. */
uint8_t hthresh; /**< Host threshold register. */
uint8_t wthresh; /**< Write-back threshold reg. */
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net/ixgbe: shrink size of context index
2026-04-08 15:48 [PATCH] net/ixgbe: shrink size of context index Bruce Richardson
@ 2026-04-09 12:18 ` Burakov, Anatoly
2026-04-09 13:45 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Burakov, Anatoly @ 2026-04-09 12:18 UTC (permalink / raw)
To: Bruce Richardson, dev
On 4/8/2026 5:48 PM, Bruce Richardson wrote:
> The ixgbe driver only supports two contexts, so using uint32_t for the
> context index is excessive. Reducing this to uint8_t shrinks the ixgbe
> part of the union from 32 bytes to 24. Although it does not in itself
> shrink the space for the whole struct, it is worth doing as ixgbe is the
> second-largest block in the union, so may become relevant if other
> rework shrinks the idpf-specific block.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/ixgbe: shrink size of context index
2026-04-09 12:18 ` Burakov, Anatoly
@ 2026-04-09 13:45 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2026-04-09 13:45 UTC (permalink / raw)
To: Burakov, Anatoly; +Cc: dev
On Thu, Apr 09, 2026 at 02:18:25PM +0200, Burakov, Anatoly wrote:
> On 4/8/2026 5:48 PM, Bruce Richardson wrote:
> > The ixgbe driver only supports two contexts, so using uint32_t for the
> > context index is excessive. Reducing this to uint8_t shrinks the ixgbe
> > part of the union from 32 bytes to 24. Although it does not in itself
> > shrink the space for the whole struct, it is worth doing as ixgbe is the
> > second-largest block in the union, so may become relevant if other
> > rework shrinks the idpf-specific block.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
Applied to dpdk-next-net-intel
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-09 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-08 15:48 [PATCH] net/ixgbe: shrink size of context index Bruce Richardson
2026-04-09 12:18 ` Burakov, Anatoly
2026-04-09 13:45 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox