From: Shaiq Wani <shaiq.wani@intel.com>
To: dev@dpdk.org, bruce.richardson@intel.com, aman.deep.singh@intel.com
Subject: [PATCH 7/7] net/ice: pin outer Ethertype for L2TPv2 flow rules
Date: Mon, 27 Apr 2026 08:01:15 +0530 [thread overview]
Message-ID: <20260427023115.1225843-8-shaiq.wani@intel.com> (raw)
In-Reply-To: <20260427023115.1225843-1-shaiq.wani@intel.com>
L2TPv2 flow rules do not include the outer Ethertype in the input set,
so a rule created for outer IPv6 also matches packets with outer IPv4
(and vice versa). The hardware profile cannot distinguish the two
families because nothing in the match key differentiates them.
Add ICE_INSET_ETHERTYPE to input_set_o and set ext_data.ether_type to
0x0800 or 0x86DD based on the outer L3 item, so the profile includes
the Ethertype field and rejects cross-family mismatches.
Fixes: 733640dae75e ("net/ice: support L2TPv2 flow pattern matching")
Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
---
drivers/net/intel/ice/ice_fdir_filter.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
index 5ea74a4a5c..2f843d66b9 100644
--- a/drivers/net/intel/ice/ice_fdir_filter.c
+++ b/drivers/net/intel/ice/ice_fdir_filter.c
@@ -2958,6 +2958,19 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
input_set_i == 0 && !ppp_present)
tunnel_type = ICE_FDIR_TUNNEL_TYPE_NONE;
+ /* Match outer IPv4/IPv6 for L2TPv2 via Ethertype. */
+ if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_L2TPV2) {
+ if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
+ input_set_o |= ICE_INSET_ETHERTYPE;
+ filter->input.ext_data.ether_type =
+ rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4);
+ } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
+ input_set_o |= ICE_INSET_ETHERTYPE;
+ filter->input.ext_data.ether_type =
+ rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV6);
+ }
+ }
+
filter->tunnel_type = tunnel_type;
filter->input.flow_type = flow_type;
filter->input_set_o = input_set_o;
--
2.43.0
next prev parent reply other threads:[~2026-04-27 2:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 2:31 [PATCH 0/7] net/ice: L2TPv2 flow rule fixes Shaiq Wani
2026-04-27 2:31 ` [PATCH 1/7] net/ice: use granular PTYPEs for L2TPv2 PPP Shaiq Wani
2026-04-27 2:31 ` [PATCH 2/7] net/ice: add tunnel inset bits to flow input set map Shaiq Wani
2026-04-27 2:31 ` [PATCH 3/7] net/ice: fix L2TPv2 inner segment header setup Shaiq Wani
2026-04-27 2:31 ` [PATCH 4/7] net/ice: fix bare L2TPv2 flow rule deletion Shaiq Wani
2026-04-27 2:31 ` [PATCH 5/7] net/ice: fix GTP-U failure due to wrong tunnel profile Shaiq Wani
2026-04-27 2:31 ` [PATCH 6/7] net/ice: fix stale profile after L2TPv2 subtype change Shaiq Wani
2026-04-27 2:31 ` Shaiq Wani [this message]
2026-04-27 9:13 ` 回复: [PATCH 7/7] net/ice: pin outer Ethertype for L2TPv2 flow rules Jiale, SongX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427023115.1225843-8-shaiq.wani@intel.com \
--to=shaiq.wani@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox