From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
stable@dpdk.org, "John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH v6 2/3] net/af_packet: fix indentation
Date: Wed, 29 Apr 2026 11:19:00 -0700 [thread overview]
Message-ID: <20260429182055.398105-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20260429182055.398105-1-stephen@networkplumber.org>
DPDK code is supposed to be indented with TABS not spaces.
Also, used "unsigned int" to keep checkpatch happy.
Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/af_packet/rte_eth_af_packet.c | 64 +++++++++++------------
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index 0ee94e71ea..8303ff5ca9 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -79,7 +79,7 @@ struct __rte_cache_aligned pkt_tx_queue {
};
struct pmd_internals {
- unsigned nb_queues;
+ unsigned int nb_queues;
int if_index;
char *if_name;
@@ -602,7 +602,7 @@ eth_dev_close(struct rte_eth_dev *dev)
static int
eth_link_update(struct rte_eth_dev *dev,
- int wait_to_complete __rte_unused)
+ int wait_to_complete __rte_unused)
{
const struct pmd_internals *internals = dev->data->dev_private;
struct rte_eth_link *dev_link = &dev->data->dev_link;
@@ -622,11 +622,11 @@ eth_link_update(struct rte_eth_dev *dev,
static int
eth_rx_queue_setup(struct rte_eth_dev *dev,
- uint16_t rx_queue_id,
- uint16_t nb_rx_desc __rte_unused,
- unsigned int socket_id __rte_unused,
- const struct rte_eth_rxconf *rx_conf __rte_unused,
- struct rte_mempool *mb_pool)
+ uint16_t rx_queue_id,
+ uint16_t nb_rx_desc __rte_unused,
+ unsigned int socket_id __rte_unused,
+ const struct rte_eth_rxconf *rx_conf __rte_unused,
+ struct rte_mempool *mb_pool)
{
struct pmd_internals *internals = dev->data->dev_private;
struct pkt_rx_queue *pkt_q = &internals->rx_queue[rx_queue_id];
@@ -660,10 +660,10 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
static int
eth_tx_queue_setup(struct rte_eth_dev *dev,
- uint16_t tx_queue_id,
- uint16_t nb_tx_desc __rte_unused,
- unsigned int socket_id __rte_unused,
- const struct rte_eth_txconf *tx_conf __rte_unused)
+ uint16_t tx_queue_id,
+ uint16_t nb_tx_desc __rte_unused,
+ unsigned int socket_id __rte_unused,
+ const struct rte_eth_txconf *tx_conf __rte_unused)
{
struct pmd_internals *internals = dev->data->dev_private;
@@ -790,8 +790,8 @@ static const struct eth_dev_ops ops = {
*/
static int
open_packet_iface(const char *key __rte_unused,
- const char *value __rte_unused,
- void *extra_args)
+ const char *value __rte_unused,
+ void *extra_args)
{
int *sockfd = extra_args;
@@ -854,17 +854,17 @@ get_fanout(const char *fanout_mode, int if_index)
static int
rte_pmd_init_internals(struct rte_vdev_device *dev,
- const int sockfd,
- const unsigned nb_queues,
- unsigned int blocksize,
- unsigned int blockcnt,
- unsigned int framesize,
- unsigned int framecnt,
+ const int sockfd,
+ const unsigned int nb_queues,
+ unsigned int blocksize,
+ unsigned int blockcnt,
+ unsigned int framesize,
+ unsigned int framecnt,
unsigned int qdisc_bypass,
const char *fanout_mode,
- struct pmd_internals **internals,
- struct rte_eth_dev **eth_dev,
- struct rte_kvargs *kvlist)
+ struct pmd_internals **internals,
+ struct rte_eth_dev **eth_dev,
+ struct rte_kvargs *kvlist)
{
const char *name = rte_vdev_device_name(dev);
const unsigned int numa_node = dev->device.numa_node;
@@ -890,7 +890,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
if (pair == NULL) {
PMD_LOG(ERR,
"%s: no interface specified for AF_PACKET ethdev",
- name);
+ name);
return -1;
}
@@ -899,7 +899,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
name, numa_node);
*internals = rte_zmalloc_socket(name, sizeof(**internals),
- 0, numa_node);
+ 0, numa_node);
if (*internals == NULL)
return -1;
@@ -1140,8 +1140,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
static int
rte_eth_from_packet(struct rte_vdev_device *dev,
- int const *sockfd,
- struct rte_kvargs *kvlist)
+ int const *sockfd,
+ struct rte_kvargs *kvlist)
{
const char *name = rte_vdev_device_name(dev);
struct pmd_internals *internals = NULL;
@@ -1172,7 +1172,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
if (qpairs < 1) {
PMD_LOG(ERR,
"%s: invalid qpairs value",
- name);
+ name);
return -1;
}
continue;
@@ -1182,7 +1182,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
if (!blocksize) {
PMD_LOG(ERR,
"%s: invalid blocksize value",
- name);
+ name);
return -1;
}
continue;
@@ -1192,7 +1192,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
if (!framesize) {
PMD_LOG(ERR,
"%s: invalid framesize value",
- name);
+ name);
return -1;
}
continue;
@@ -1202,7 +1202,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
if (!framecount) {
PMD_LOG(ERR,
"%s: invalid framecount value",
- name);
+ name);
return -1;
}
continue;
@@ -1226,7 +1226,7 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
if (framesize > blocksize) {
PMD_LOG(ERR,
"%s: AF_PACKET MMAP frame size exceeds block size!",
- name);
+ name);
return -1;
}
@@ -1301,7 +1301,7 @@ rte_pmd_af_packet_probe(struct rte_vdev_device *dev)
if (rte_kvargs_count(kvlist, ETH_AF_PACKET_IFACE_ARG) == 1) {
ret = rte_kvargs_process(kvlist, ETH_AF_PACKET_IFACE_ARG,
- &open_packet_iface, &sockfd);
+ &open_packet_iface, &sockfd);
if (ret < 0)
goto exit;
}
--
2.53.0
next prev parent reply other threads:[~2026-04-29 18:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 23:00 [PATCH 1/2] net/af_packet: fix indentation Stephen Hemminger
2026-04-13 23:00 ` [PATCH 2/2] test: add test for af_packet Stephen Hemminger
2026-04-14 15:52 ` [PATCH v2 0/2] af_packet: cleanup and test Stephen Hemminger
2026-04-14 15:52 ` [PATCH v2 1/2] net/af_packet: whitespace cleanup Stephen Hemminger
2026-04-14 15:52 ` [PATCH v2 2/2] test: add test for af_packet Stephen Hemminger
2026-04-28 14:13 ` [PATCH v5 0/2] af_packet: cleanup and add test Stephen Hemminger
2026-04-28 14:13 ` [PATCH v5 1/2] net/af_packet: fix indentation Stephen Hemminger
2026-04-28 14:13 ` [PATCH v5 2/2] test: add test for af_packet Stephen Hemminger
2026-04-29 18:18 ` [PATCH v6 0/3] af_packet: cleanup and add test Stephen Hemminger
2026-04-29 18:18 ` [PATCH v6 1/3] maintainers: nominate myself for af_packet Stephen Hemminger
2026-04-29 18:19 ` Stephen Hemminger [this message]
2026-04-29 18:19 ` [PATCH v6 3/3] test: add test " Stephen Hemminger
2026-04-30 17:22 ` [PATCH v6 0/3] af_packet: cleanup and add test Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429182055.398105-3-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox