From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AADDCD3427 for ; Tue, 5 May 2026 20:45:20 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0558340697; Tue, 5 May 2026 22:45:16 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id BF17C4068A; Tue, 5 May 2026 22:45:14 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1202) id F402320B7168; Tue, 5 May 2026 13:45:11 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F402320B7168 From: Long Li To: dev@dpdk.org, Wei Hu , Stephen Hemminger Cc: Long Li , stable@dpdk.org Subject: [PATCH 2/7] net/netvsc: retry on SIOCGIFHWADDR failure during VF hotplug Date: Tue, 5 May 2026 13:44:51 -0700 Message-ID: <20260505204457.267934-2-longli@microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260505204457.267934-1-longli@microsoft.com> References: <20260505204457.267934-1-longli@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the MANA VF net directory appears after PCI rescan, udev may rename the interface (e.g. eth1 → ens1) before DPDK can query its MAC address via SIOCGIFHWADDR. The ioctl fails because the interface name is stale during the rename window. Instead of giving up when SIOCGIFHWADDR fails, close the directory and schedule another retry. The next attempt will re-read the directory with the updated interface name (e.g. ens1 instead of eth1) and succeed. This was observed on Azure VMs where the MANA kernel driver takes >30 seconds to probe after PCI rescan, and udev renames the interface immediately after registration. Fixes: a2a23a794b3a ("net/netvsc: support VF device hot add/remove") Cc: stable@dpdk.org Signed-off-by: Long Li --- drivers/net/netvsc/hn_ethdev.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 61e5aa464d..8bb2df3c19 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -667,10 +667,17 @@ static void netvsc_hotplug_retry(void *args) ret = ioctl(s, SIOCGIFHWADDR, &req); close(s); if (ret == -1) { - PMD_DRV_LOG(ERR, - "Failed to send SIOCGIFHWADDR for device %s", + /* Interface may be renamed by udev (e.g. eth1 → ens1), + * retry instead of giving up. + */ + PMD_DRV_LOG(NOTICE, + "Failed to send SIOCGIFHWADDR for device %s, " + "interface may be renaming, retrying", dir->d_name); - break; + closedir(di); + rte_eal_alarm_set(NETVSC_HOTADD_RETRY_INTERVAL, + netvsc_hotplug_retry, hot_ctx); + return; } if (req.ifr_hwaddr.sa_family != ARPHRD_ETHER) continue; -- 2.43.0