From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 055CACD342F for ; Wed, 6 May 2026 02:05:54 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDBEB4068E; Wed, 6 May 2026 04:05:44 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 5A2204064F; Wed, 6 May 2026 04:05:43 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1202) id 7379820B7169; Tue, 5 May 2026 19:05:40 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7379820B7169 From: Long Li To: dev@dpdk.org, Wei Hu , Stephen Hemminger Cc: Long Li , stable@dpdk.org Subject: [PATCH v2 3/7] net/netvsc: retry full probe when IB device not ready during hotplug Date: Tue, 5 May 2026 19:05:24 -0700 Message-ID: <20260506020529.281654-3-longli@microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260506020529.281654-1-longli@microsoft.com> References: <20260506020529.281654-1-longli@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When rte_eal_hotplug_add returns -ENODEV during VF hot-add, it means the MANA IB/verbs device is not yet registered by the mana_ib kernel module. This happens because the mana_ib auxiliary driver probes asynchronously after the MANA net driver creates the network interface. On Azure VMs, the gap between netdev registration and IB device registration can be several seconds. Previously, netvsc would log the error and give up after finding the matching MAC address. Now, on -ENODEV, restart the full retry loop from the PCI device existence check. This re-scans the net directory to pick up any interface renames (e.g. eth1 -> ens1) and retries until the IB device is ready. The -EEXIST return (device already probed by another netvsc port on the same PCI device) is handled silently, as hn_vf_add will find the already-probed VF port. Fixes: a2a23a794b3a ("net/netvsc: support VF device hot add/remove") Cc: stable@dpdk.org Signed-off-by: Long Li --- v2: - Restored ERR log level for non-ENODEV/non-EEXIST failures from rte_eal_hotplug_add (was incorrectly lowered to NOTICE) - Added comment explaining why ENODEV retry is safe (bounded by PCI sysfs disappearance) drivers/net/netvsc/hn_ethdev.c | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 1fa64cab18..130fea38ab 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -716,17 +716,36 @@ static void netvsc_hotplug_retry(void *args) * parent device, restore its args. */ ret = rte_eal_hotplug_add(d->bus->name, d->name, drv_str ? drv_str : ""); - if (ret) { - PMD_DRV_LOG(ERR, - "Failed to add PCI device %s", + free(drv_str); + + if (ret == -ENODEV) { + /* IB device not ready yet (mana_ib not probed). + * Restart the full retry from the PCI device + * check so we re-verify the device exists and + * get fresh interface names after any renames. + * This retries indefinitely — the PCI sysfs + * check at the top of this function ensures + * we stop if the device disappears. + */ + PMD_DRV_LOG(NOTICE, + "IB device not ready for %s, " + "restarting probe in 1 second", d->name); + closedir(di); + rte_eal_alarm_set(NETVSC_HOTADD_RETRY_INTERVAL, + netvsc_hotplug_retry, + hot_ctx); + return; } - free(drv_str); + if (ret && ret != -EEXIST) + PMD_DRV_LOG(ERR, + "Failed to add PCI device %s (ret=%d)", + d->name, ret); ret = hn_vf_add(dev, hv); if (ret) - PMD_DRV_LOG(ERR, "Failed to add VF in hotplug retry: %d", ret); + PMD_DRV_LOG(ERR, "Failed to add VF: %d", ret); break; } } -- 2.43.0