From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA25CD342F for ; Fri, 8 May 2026 20:37:40 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B507F40B8F; Fri, 8 May 2026 22:36:30 +0200 (CEST) Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) by mails.dpdk.org (Postfix) with ESMTP id C0C4C40A77 for ; Fri, 8 May 2026 22:36:26 +0200 (CEST) Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-1309f4ee97fso3260799c88.1 for ; Fri, 08 May 2026 13:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1778272586; x=1778877386; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l8/kSagyHm7d8K+kImZdOd18Ksp4U2IJ7WeVOucD7tw=; b=PI9HY+X7ftVrkVIT1H47fG2RHD+dzNp1IqxdufMiJ/+uiBHcKbvvXguJ94R6i9LS9k QAsrTPx2/lDnTBopeWEHAUUW9WpdcO35EdbHtrTXKCjixttVnJ1ALNJXlDCmqIls0vRA Nns9HtriBXOZb3idkGtoVQuj70C9Y3ryNih1r+SQ55cPnzD8hW9Jmzt7UN3i2+rmaEOu l2gWUAPtMTeMqZ0OGBI1ZlEu7hNUOznrvvegKEuXGiL87ysnH+6w4fC+5ZFnHaN6nAuI HC9i0NVMIn7xZeXkdzFtpTq9qp/yBbFxWqo3iDIxiX7tn2GoCOuI4jA6D6hyOl9mUABa 8sPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778272586; x=1778877386; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=l8/kSagyHm7d8K+kImZdOd18Ksp4U2IJ7WeVOucD7tw=; b=m/mvT8MOPc3AxFNiZ5s9uE2Lxt8OlTahc/2TwSsx3reNTrel+248dQ1YpJ98rlDPhJ E+pRImng8Td7p53wCCHaC2vXl7RWH1D3TRBUDgDPvCbb0HinmMaMf5xnUyrIX6dUEqXS YDZXaI737JP5SEiL+d73VM1v/vNvfZwELdbbYwM7l6YiZ/+Zf59CK2h8z+nwokOd5ch/ 850OApXu5h2k6+i99SPsDsDHKGPqdCQ2z06hfqzt/AK3WCf7bTYLv3hHbwZNJJBL0eDR 4nw+f57t+cH1MlgEkmTcvDT1nPfSPTrgy+nnB5wzgv3SRkENR5TslLno7FaiXTv8xJuX /mmw== X-Gm-Message-State: AOJu0YwKb/H2NP9DbZL74yfnWY30EtnJMM43jYODTaICFOwsvM5T8xy6 ixcTX57835+kzscr9KXMe5By+m1etxhkLibcHWLjabisuXj9iXu/dM4D9B3BYZcGEQxc/aP6iK/ EdLQD X-Gm-Gg: AeBDietWdFkYJqU+7QE0OtnVOmutpMes425fk3jroZ2+dijBijn5pbI2IzkYmaTFOKO X85jiiVrylzu6KtEW+gqoZzi3lVEP4Bn9CF9/mhpboEhJ8AvVEQymMU8UtV7ddW0Nx3dltuuASH jsXX+vHGyNNkLEYTM5C/7MK25M3ibg9QiTnlM6q8dOgePhXHeaLdQoRbJofiaBbdUe1ofltmDvx xINUvAGksxwTQHQnopU2IS0H/9jZGaR9BDYr9xkHbgNPH3cWipoQvn2pwdOIaPCBtGMtH2LTWrP FTujqDruQk/PG5jZ6Xa5mx3WVItcuaTLCuUGBKRx1u/SF7jjK9yQBshXpKt8yjxsigV9cj+wpiP u1u0EvWBcqLv7KM0IEkCfu+p9PM3pKtjSH5HQWwl0IacBZmbshWWdvzy/pOf0XJfwZPlfvu1L7A YETZS/XcTjmka3OSprv0oUBUm0iPjxYrkKNlgzOT3mSkA8kBN2p0g0hw== X-Received: by 2002:a05:7022:4a9:b0:12d:de3e:be88 with SMTP id a92af1059eb24-131a69f2f19mr6661936c88.36.1778272585755; Fri, 08 May 2026 13:36:25 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8859eafcdsm4715146eec.6.2026.05.08.13.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 13:36:25 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kishore Padmanabha , Ajit Khaparde Subject: [PATCH 16/20] net/bnxt: remove unnecessary null check Date: Fri, 8 May 2026 13:33:37 -0700 Message-ID: <20260508203607.1003036-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260508203607.1003036-1-stephen@networkplumber.org> References: <20260508203607.1003036-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove unnecessary if check before calling rte_free. Generated by devtools/cocci/null_free.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/tf_core/v3/tfo.c | 6 ++---- drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/tf_core/v3/tfo.c b/drivers/net/bnxt/tf_core/v3/tfo.c index 4b1f545476..681d1dd8d3 100644 --- a/drivers/net/bnxt/tf_core/v3/tfo.c +++ b/drivers/net/bnxt/tf_core/v3/tfo.c @@ -183,13 +183,11 @@ void tfo_close(void **tfo) } } } - if (tim) - rte_free(tim); + rte_free(tim); tfco->ts_tim = NULL; tfco->tfgo = NULL; - if (*tfo) - rte_free(*tfo); + rte_free(*tfo); *tfo = NULL; } } diff --git a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c index 23e1b59ca4..3707cd1a2d 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c +++ b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c @@ -169,11 +169,9 @@ ulp_sc_mgr_deinit(struct bnxt_ulp_context *ctxt) ulp_sc_mgr_thread_cancel(ctxt); - if (ulp_sc_info->stats_cache_tbl) - rte_free(ulp_sc_info->stats_cache_tbl); + rte_free(ulp_sc_info->stats_cache_tbl); - if (ulp_sc_info->read_data) - rte_free(ulp_sc_info->read_data); + rte_free(ulp_sc_info->read_data); rte_free(ulp_sc_info); -- 2.53.0