DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Long Li <longli@microsoft.com>
Cc: dev@dpdk.org, Wei Hu <weh@microsoft.com>
Subject: Re: [PATCH v3 0/7] net/netvsc: fix VF hotplug and service reset handling
Date: Sun, 17 May 2026 19:59:54 -0700	[thread overview]
Message-ID: <20260517195954.12865a1d@phoenix.local> (raw)
In-Reply-To: <20260515192843.552762-1-longli@microsoft.com>

On Fri, 15 May 2026 12:28:34 -0700
Long Li <longli@microsoft.com> wrote:

> This series fixes several issues in the netvsc PMD's VF hot-plug retry
> logic and adds support for MANA service reset (suspend/resume) recovery.
> 
> Patches 1-5 fix the VF hot-add retry path to handle Azure-specific
> timing issues: slow MANA driver probe (>100s), udev interface renames,
> asynchronous mana_ib registration, and multi-NIC staggered VF
> appearance.
> 
> Patch 6 fixes per-queue stats forwarding from VF to netvsc.
> 
> Patch 7 adds recovery event handling for MANA service resets, where
> the kernel suspends/resumes the VF without PCI remove.
> 
> v3:
> - Patch 1: wrapped rte_eal_alarm_set lines to fix checkpatch
>   line-length warning
> - Patch 4: changed "retry loop exiting" log from NOTICE to DEBUG
>   to avoid noise on every successful VF re-attach
> - Patch 6: removed dead -ENOTSUP fallback to rte_eth_stats_get,
>   replaced with direct -ENOTSUP return; documented caller contract
>   for zeroed buffers
> - Patch 7: deferred all recovery callbacks via rte_eal_alarm_set
>   consistent with INTR_RMV pattern; dropped unlocked vf_attached
>   guard in recovery_failed; cancel new alarms in hn_vf_close
> 
> v2:
> - Patch 1: added comment explaining why indefinite retry is safe
> - Patch 2: changed SIOCGIFHWADDR retry log to DEBUG
> - Patch 3: restored ERR log for non-ENODEV/EEXIST failures
> - Patch 4: changed per-iteration logs from NOTICE to DEBUG;
>   used RTE_ETHER_ADDR_PRT_FMT macros
> - Patch 5: fixed commit message (limit 120 not 30); changed
>   mac_retry log to DEBUG; explicit NULL comparisons
> - Patch 6: added comment for direct dev_ops call; added -ENOTSUP
>   fallback
> - Patch 7: added dev_started check in recovery_success; added
>   vf_attached guard in recovery_failed
> 
> Long Li (7):
>   net/netvsc: retry VF hotplug indefinitely until PCI device disappears
>   net/netvsc: retry on SIOCGIFHWADDR failure during VF hotplug
>   net/netvsc: retry full probe when IB device not ready during hotplug
>   net/netvsc: add debug logging for VF hotplug retry
>   net/netvsc: retry when no matching MAC found in net directory
>   net/netvsc: forward per-queue stats from VF device
>   net/netvsc: handle VF recovery events for service reset
> 
>  drivers/net/netvsc/hn_ethdev.c | 142 +++++++++++++++++++++----
>  drivers/net/netvsc/hn_var.h    |   1 +
>  drivers/net/netvsc/hn_vf.c     | 182 ++++++++++++++++++++++++++++++++-
>  3 files changed, 302 insertions(+), 23 deletions(-)
> 

Applied to next-net

      parent reply	other threads:[~2026-05-18  3:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06  2:05 [PATCH v2 1/7] net/netvsc: retry VF hotplug indefinitely until PCI device disappears Long Li
2026-05-06  2:05 ` [PATCH v2 2/7] net/netvsc: retry on SIOCGIFHWADDR failure during VF hotplug Long Li
2026-05-06  2:05 ` [PATCH v2 3/7] net/netvsc: retry full probe when IB device not ready during hotplug Long Li
2026-05-06  2:05 ` [PATCH v2 4/7] net/netvsc: add debug logging for VF hotplug retry Long Li
2026-05-06  2:05 ` [PATCH v2 5/7] net/netvsc: retry when no matching MAC found in net directory Long Li
2026-05-06  2:05 ` [PATCH v2 6/7] net/netvsc: forward per-queue stats from VF device Long Li
2026-05-06  2:05 ` [PATCH v2 7/7] net/netvsc: handle VF recovery events for service reset Long Li
2026-05-07  2:49 ` [PATCH v2 1/7] net/netvsc: retry VF hotplug indefinitely until PCI device disappears Stephen Hemminger
2026-05-15 19:45   ` [EXTERNAL] " Long Li
2026-05-15 19:28 ` [PATCH v3 0/7] net/netvsc: fix VF hotplug and service reset handling Long Li
2026-05-15 19:28   ` [PATCH v3 1/7] net/netvsc: retry VF hotplug indefinitely until PCI device disappears Long Li
2026-05-15 19:28   ` [PATCH v3 2/7] net/netvsc: retry on SIOCGIFHWADDR failure during VF hotplug Long Li
2026-05-15 19:28   ` [PATCH v3 3/7] net/netvsc: retry full probe when IB device not ready during hotplug Long Li
2026-05-15 19:28   ` [PATCH v3 4/7] net/netvsc: add debug logging for VF hotplug retry Long Li
2026-05-15 19:28   ` [PATCH v3 5/7] net/netvsc: retry when no matching MAC found in net directory Long Li
2026-05-15 19:28   ` [PATCH v3 6/7] net/netvsc: forward per-queue stats from VF device Long Li
2026-05-15 19:28   ` [PATCH v3 7/7] net/netvsc: handle VF recovery events for service reset Long Li
2026-05-18  2:59   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260517195954.12865a1d@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=longli@microsoft.com \
    --cc=weh@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox