From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: fengchengwen <fengchengwen@huawei.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
thomas@monjalon.net, dev@dpdk.org
Subject: Re: [PATCH 0/2] enhance telemetry list endpoint with device name
Date: Wed, 20 May 2026 07:54:03 -0700 [thread overview]
Message-ID: <20260520075403.5483c20a@phoenix.local> (raw)
In-Reply-To: <ag1nny7mJpM1pum6@bricha3-mobl1.ger.corp.intel.com>
On Wed, 20 May 2026 08:49:51 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> On Wed, May 20, 2026 at 03:31:57PM +0800, fengchengwen wrote:
> > On 5/20/2026 1:40 PM, Morten Brørup wrote:
> > >> From: Chengwen Feng [mailto:fengchengwen@huawei.com]
> > >> Sent: Wednesday, 20 May 2026 05.57
> > >>
> > >> Currently, the /dmadev/list and /ethdev/list telemetry endpoints return
> > >> only integer IDs, making it hard to identify devices. This series
> > >> changes
> > >> both to output strings in "ID NAME" format for better usability.
> > >
> > > For machine reading of the JSON output, it would be better returning an object with an integer and a string field, {ID, "NAME"}.
> >
> > The TEL_DICT could do {"ID", "NAME"}, which like:
> > "/ethdev/list": {
> > "0": "0000:7d:00.0",
> > "1": "0000:7d:00.1"
> > }
> >
> > Maybe we could add one TEL_INT_DICT which is int-value pairs, we may get:
> > "/ethdev/list": {
> > 0: "0000:7d:00.0",
> > 1: "0000:7d:00.1"
> > }
> >
> > I prefer the first one, However, the capacity is reduced from 512 (RTE_TEL_MAX_ARRAY_ENTRIES) to 256 (RTE_TEL_MAX_DICT_ENTRIES), but I think it is enough.
> >
> > What's your opinion?
> >
>
> I'm not sure about this change at all. This change is only relevant for
> those using the script interactively, for any other use, I would expect the
> the /ethdev/list call would be followed by the /ethdev/info calls for each
> port to get the name. That was the basic design in mind for this, the list
> call was purely to provide the ids, any other info you make separate calls
> for.
>
> Also, while not officially part of the ABI of DPDK, I think it would be
> wrong to go changing the types of the returned data from this /ethdev/list
> call. Any user-written interfaces to telemetry will be relying on the
> current behaviour to list and query ports. If you really want to have an
> easy way to get the names of the ports, I suggest adding instead an
> "/ethdev/list_names" API, which can either return the objects above, or
> else simply an array of names.
>
> /Bruce
The new wireshark extcap needs similar device list.
Ideally returning similar format to existing dpdk-dumpcap -D
next prev parent reply other threads:[~2026-05-20 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 3:56 [PATCH 0/2] enhance telemetry list endpoint with device name Chengwen Feng
2026-05-20 3:56 ` [PATCH 1/2] dmadev: include device name in telemetry list output Chengwen Feng
2026-05-20 15:03 ` Stephen Hemminger
2026-05-20 3:56 ` [PATCH 2/2] ethdev: " Chengwen Feng
2026-05-20 5:40 ` [PATCH 0/2] enhance telemetry list endpoint with device name Morten Brørup
2026-05-20 7:31 ` fengchengwen
2026-05-20 7:49 ` Bruce Richardson
2026-05-20 14:54 ` Stephen Hemminger [this message]
2026-05-20 9:38 ` [PATCH v2 0/2] Add list names telemetry endpoint Chengwen Feng
2026-05-20 9:38 ` [PATCH v2 1/2] dmadev: add telemetry endpoint for list names Chengwen Feng
2026-05-20 9:38 ` [PATCH v2 2/2] ethdev: " Chengwen Feng
2026-05-20 13:29 ` Morten Brørup
2026-05-20 14:58 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520075403.5483c20a@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox