From: Stephen Hemminger <stephen@networkplumber.org>
To: "Mattias Rönnblom" <hofors@lysator.liu.se>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
"Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Yogaraj Baskaravel" <yogaraj.baskaravel@ericsson.com>
Subject: Re: [RFC 2/3] lib: add fastmem library
Date: Wed, 27 May 2026 07:22:51 -0700 [thread overview]
Message-ID: <20260527072251.7c53719d@phoenix.local> (raw)
In-Reply-To: <20260525103642.55255-3-hofors@lysator.liu.se>
On Mon, 25 May 2026 12:36:41 +0200
Mattias Rönnblom <hofors@lysator.liu.se> wrote:
> +
> +static __rte_always_inline struct fastmem_cache *
> +cache_get(struct fastmem_socket_state *socket, unsigned int class_idx,
> + unsigned int lcore_id)
Do not use always_inline. With current compilers using always inline
makes the optimizer generate worse code. The only exceptions would
be where inline is required to make assembly work or you have good benchmark
data that proves that always_inline generates > 1% performance gain.
To much of DPDK use __rte_always_inline as "cargo cult" it is faster setting.
next prev parent reply other threads:[~2026-05-27 14:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 10:36 [RFC 0/3] lib/fastmem: fast small-object allocator Mattias Rönnblom
2026-05-25 10:36 ` [RFC 1/3] doc: add fastmem programming guide Mattias Rönnblom
2026-05-25 10:36 ` [RFC 2/3] lib: add fastmem library Mattias Rönnblom
2026-05-27 14:22 ` Stephen Hemminger [this message]
2026-05-27 17:25 ` Mattias Rönnblom
2026-05-25 10:36 ` [RFC 3/3] app/test: add fastmem test suite Mattias Rönnblom
2026-05-26 8:57 ` [RFC v2 0/3] lib/fastmem: fast small-object allocator Mattias Rönnblom
2026-05-26 8:57 ` [RFC v2 1/3] doc: add fastmem programming guide Mattias Rönnblom
2026-05-26 8:57 ` [RFC v2 2/3] lib: add fastmem library Mattias Rönnblom
2026-05-26 13:23 ` Stephen Hemminger
2026-05-27 10:12 ` Mattias Rönnblom
2026-05-27 10:18 ` Bruce Richardson
2026-05-27 11:17 ` Mattias Rönnblom
2026-05-27 11:17 ` Morten Brørup
2026-05-27 11:29 ` Mattias Rönnblom
2026-05-27 12:03 ` Morten Brørup
2026-05-26 8:57 ` [RFC v2 3/3] app/test: add fastmem test suite Mattias Rönnblom
2026-05-27 17:30 ` [RFC v3 0/3] lib/fastmem: fast small-object allocator Mattias Rönnblom
2026-05-27 17:30 ` [RFC v3 1/3] doc: add fastmem programming guide Mattias Rönnblom
2026-05-30 9:26 ` [RFC v4 0/3] lib/fastmem: fast small-object allocator Mattias Rönnblom
2026-05-30 9:26 ` [RFC v4 1/3] doc: add fastmem programming guide Mattias Rönnblom
2026-05-30 9:26 ` [RFC v4 2/3] lib: add fastmem library Mattias Rönnblom
2026-05-30 9:26 ` [RFC v4 3/3] app/test: add fastmem test suite Mattias Rönnblom
2026-05-27 17:30 ` [RFC v3 2/3] lib: add fastmem library Mattias Rönnblom
2026-05-28 9:11 ` Morten Brørup
2026-05-28 14:45 ` Varghese, Vipin
2026-05-28 19:56 ` Morten Brørup
2026-05-29 14:29 ` Varghese, Vipin
2026-05-30 16:22 ` Mattias Rönnblom
2026-05-27 17:30 ` [RFC v3 3/3] app/test: add fastmem test suite Mattias Rönnblom
2026-05-28 9:02 ` [RFC v3 0/3] lib/fastmem: fast small-object allocator Morten Brørup
2026-05-25 14:30 ` [RFC " Stephen Hemminger
2026-05-25 19:39 ` Mattias Rönnblom
2026-05-25 22:18 ` Stephen Hemminger
2026-05-26 7:01 ` Mattias Rönnblom
2026-05-25 18:36 ` Stephen Hemminger
2026-05-25 19:43 ` Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527072251.7c53719d@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=konstantin.ananyev@huawei.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=yogaraj.baskaravel@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox