From: Stephen Hemminger <stephen@networkplumber.org>
To: James Raphael Tiovalen <jamestiotio@gmail.com>
Cc: orika@nvidia.com, thomas@monjalon.net,
andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH 1/2] ethdev: fix out-of-bounds write in GENEVE option conversion
Date: Wed, 27 May 2026 08:38:42 -0700 [thread overview]
Message-ID: <20260527083842.32de94f6@phoenix.local> (raw)
In-Reply-To: <20260526181159.287633-2-jamestiotio@gmail.com>
On Wed, 27 May 2026 02:11:58 +0800
James Raphael Tiovalen <jamestiotio@gmail.com> wrote:
> rte_flow_conv_item_spec() is documented to truncate output to the
> caller-supplied buffer size. For RTE_FLOW_ITEM_TYPE_GENEVE_OPT, the
> deep-copy of the variable-length option data was gated on `size > 0`
> instead of `size >= off + tmp`, the form used by the sibling RAW
> branch. A caller passing a buffer just large enough for the header
> struct had adjacent memory clobbered by up to `option_len * 4` bytes of
> option payload.
>
> Align the GENEVE_OPT guard with the RAW one.
>
> Fixes: 841a0445442d ("ethdev: fix GENEVE option item conversion")
> Cc: stable@dpdk.org
>
> Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
> ---
Does not apply to current main branch.
There were recent fixes in this area.
Rebase and resubmit please.
next prev parent reply other threads:[~2026-05-27 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 18:11 [PATCH 0/2] ethdev: fix out-of-bounds writes in rte_flow_conv() James Raphael Tiovalen
2026-05-26 18:11 ` [PATCH 1/2] ethdev: fix out-of-bounds write in GENEVE option conversion James Raphael Tiovalen
2026-05-27 15:38 ` Stephen Hemminger [this message]
2026-05-26 18:11 ` [PATCH 2/2] ethdev: fix out-of-bounds write in flex item conversion James Raphael Tiovalen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527083842.32de94f6@phoenix.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jamestiotio@gmail.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox