From: Stephen Hemminger <stephen@networkplumber.org>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Cc: <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
"Sunil Kumar Kori" <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
"Harman Kalra" <hkalra@marvell.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
"Anoob Joseph" <anoobj@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>
Subject: Re: [v1] crypto/cnxk: add ML crypto support
Date: Fri, 29 May 2026 08:25:30 -0700 [thread overview]
Message-ID: <20260529082530.3a57c61f@phoenix.local> (raw)
In-Reply-To: <20260529091330.6308-1-gmuthukrishn@marvell.com>
On Fri, 29 May 2026 14:43:26 +0530
Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> wrote:
> +/* ML table address and length */
> +struct re_ml_entry {
> + const uint8_t *data;
> + int len;
> +};
Better to use unsigned for size like size_t
> +
> +struct re_ml_tbl {
> + PLT_ATOMIC(uint64_t) refcount;
> + uint8_t ml_tbl[];
> +};
> +
> +const uint8_t re_mlkem_zeta_tbl[RE_MLKEM_ZETA_LEN] = {
Tables should be local to file so static?
next prev parent reply other threads:[~2026-05-29 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 9:13 [v1] crypto/cnxk: add ML crypto support Gowrishankar Muthukrishnan
2026-05-29 15:25 ` Stephen Hemminger [this message]
2026-05-29 15:27 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529082530.3a57c61f@phoenix.local \
--to=stephen@networkplumber.org \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=gmuthukrishn@marvell.com \
--cc=hkalra@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ktejasree@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox