From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
<dev@dpdk.org>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH] app/test: use memcpy in ipsec test
Date: Fri, 29 May 2026 15:52:54 -0700 [thread overview]
Message-ID: <20260529155254.6f563f48@phoenix.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F658B7@smartserver.smartshare.dk>
On Fri, 29 May 2026 22:45:00 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> > > @@ -604,22 +603,22 @@ setup_test_string_tunneled(struct rte_mempool
> > > *mpool, const char *string,
> > > /* copy outer IP and ESP header */
> > > ipv4_outer.total_length = rte_cpu_to_be_16(t_len);
> > > ipv4_outer.packet_id = rte_cpu_to_be_16(seq);
> > > - rte_memcpy(dst, &ipv4_outer, sizeof(ipv4_outer));
> > > + memcpy(dst, &ipv4_outer, sizeof(ipv4_outer));
>
> How about:
> *dst = ipv4_outer;
>
> Don't know if it applies here.
Good idea but dst is char *.
I suppose could use a cast but at that point the good
properties of assignment disappear.
Didn't want to go changing other code.
next prev parent reply other threads:[~2026-05-29 22:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 15:46 [PATCH] app/test: use memcpy in ipsec test Stephen Hemminger
2026-05-29 16:42 ` Konstantin Ananyev
2026-05-29 20:45 ` Morten Brørup
2026-05-29 22:52 ` Stephen Hemminger [this message]
2026-05-30 5:31 ` Morten Brørup
2026-05-29 22:58 ` Stephen Hemminger
2026-05-30 5:36 ` Morten Brørup
2026-06-02 19:36 ` [EXTERNAL] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529155254.6f563f48@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox