From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH] devtools: add Vertex AI to review scripts
Date: Mon, 1 Jun 2026 08:11:09 -0700 [thread overview]
Message-ID: <20260601081109.49968797@phoenix.local> (raw)
In-Reply-To: <bUYoD1-ARAaefqQHkOtV4Q@monjalon.net>
On Mon, 01 Jun 2026 16:21:25 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> 01/06/2026 15:24, David Marchand:
> > + if args.auth == "auto":
> > + auth_method = detect_auth_method(args.provider)
> > + else:
> > + auth_method = args.auth
> > +
> > + if auth_method == "vertex":
> > + if not VERTEX_AI_AVAILABLE:
> > + error("Vertex AI support requires 'google-auth' library. Install with: pip install google-auth")
> > + auth = "vertex"
> > + else:
> > + api_key = os.environ.get(config["env_var"])
> > + if not api_key:
> > + error(f"{config['env_var']} environment variable not set")
> > + auth = f"direct:{api_key}"
>
> Could we have such code in the common file?
Yes please add to devtools/ai/_common.py used by both review-doc and review-patch
next prev parent reply other threads:[~2026-06-01 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 13:24 [PATCH] devtools: add Vertex AI to review scripts David Marchand
2026-06-01 14:21 ` Thomas Monjalon
2026-06-01 14:39 ` David Marchand
2026-06-01 15:11 ` Stephen Hemminger [this message]
2026-06-02 6:44 ` [PATCH v2] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601081109.49968797@phoenix.local \
--to=stephen@networkplumber.org \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox