From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] ethdev: promote experimental API's to stable
Date: Mon, 1 Jun 2026 08:30:41 -0700 [thread overview]
Message-ID: <20260601083041.31c6db22@phoenix.local> (raw)
In-Reply-To: <CAJFAV8ztviupv0rcjvL9MkBQSzY+yfak0RK8GzNbe-8s5JiyEw@mail.gmail.com>
On Mon, 1 Jun 2026 13:55:13 +0200
David Marchand <david.marchand@redhat.com> wrote:
> On Wed, 27 May 2026 at 16:44, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > + * ``rte_eth_macaddrs_get``
>
> I am not enthousiastic on marking this stable.
> It more or less sets in stone that the mac addresses are stored in an array.
The device could store the mac addresses in any form.
Your right that right now the implementation of the API depends on dev->data->mac_addrs.
But if that changed, having API to walk the macs would be good.
Maybe rte_eth_macaddrs_get should scrub out empty zero slots now?
prev parent reply other threads:[~2026-06-01 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 14:44 [PATCH] ethdev: promote experimental API's to stable Stephen Hemminger
2026-06-01 9:07 ` Andrew Rybchenko
2026-06-01 11:55 ` David Marchand
2026-06-01 15:26 ` Stephen Hemminger
2026-06-01 15:30 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601083041.31c6db22@phoenix.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox