DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Denis Sergeev <denserg.edu@gmail.com>
Cc: dev@dpdk.org, shepard.siegel@atomicrules.com,
	ed.czeck@atomicrules.com, john.miller@atomicrules.com,
	stable@dpdk.org, sdl.dpdk@linuxtesting.org
Subject: Re: [PATCH] net/ark: fix null dereference on allocation failure
Date: Wed, 3 Jun 2026 08:31:04 -0700	[thread overview]
Message-ID: <20260603082738.1d94ed4d@phoenix.local> (raw)
In-Reply-To: <20260603052207.118688-1-denserg.edu@gmail.com>

On Wed,  3 Jun 2026 08:21:54 +0300
Denis Sergeev <denserg.edu@gmail.com> wrote:

> +		if (eth_dev->data->dev_private == NULL) {
> +			ARK_PMD_LOG(ERR,
> +				    "Memory allocation for dev_private failed!"
> +				    " Exiting.\n");

Do not split error messages across lines. And no need for ! and the Exiting part.

      parent reply	other threads:[~2026-06-03 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03  5:21 [PATCH] net/ark: fix null dereference on allocation failure Denis Sergeev
2026-06-03  5:32 ` [PATCH v2] " Denis Sergeev
2026-06-03 16:32   ` [PATCH v3] " Denis Sergeev
2026-06-03 15:31 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603082738.1d94ed4d@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=denserg.edu@gmail.com \
    --cc=dev@dpdk.org \
    --cc=ed.czeck@atomicrules.com \
    --cc=john.miller@atomicrules.com \
    --cc=sdl.dpdk@linuxtesting.org \
    --cc=shepard.siegel@atomicrules.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox