From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>
Subject: [PATCH 1/2] net/ice: revert fix link up when starting device
Date: Wed, 3 Jun 2026 14:34:06 +0000 [thread overview]
Message-ID: <20260603143407.1108527-2-ciara.loftus@intel.com> (raw)
In-Reply-To: <20260603143407.1108527-1-ciara.loftus@intel.com>
This reverts commit 6c76b76dc64183eb2f24a52b90d4ff9feb4872f4.
The reverted commit worked around a potential timing issue where the
link could be reported down immediately after the link was enabled
during device start. The commit introduced a blocking wait which gave
the driver a better chance to read the correct link state before
returning from device start. However, since the auto link update flag is
set when setting the link up in device start, an adminq notification
should arrive once the link is up, which will be handled and correctly
set the link status. This means we can remove the delay from device
start as it does not need to guarantee link up before returning.
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
drivers/net/intel/ice/ice_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
index d2734b6688..da570d03cb 100644
--- a/drivers/net/intel/ice/ice_ethdev.c
+++ b/drivers/net/intel/ice/ice_ethdev.c
@@ -4464,7 +4464,7 @@ ice_dev_start(struct rte_eth_dev *dev)
ice_dev_set_link_up(dev);
/* Call get_link_info aq command to enable/disable LSE */
- ice_link_update(dev, 1);
+ ice_link_update(dev, 0);
pf->adapter_stopped = false;
--
2.43.0
next prev parent reply other threads:[~2026-06-03 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 14:34 [PATCH 0/2] net/intel: fix blocking link wait on device start Ciara Loftus
2026-06-03 14:34 ` Ciara Loftus [this message]
2026-06-09 10:20 ` [PATCH 1/2] net/ice: revert fix link up when starting device Bruce Richardson
2026-06-09 11:55 ` Bruce Richardson
2026-06-09 12:53 ` Loftus, Ciara
2026-06-03 14:34 ` [PATCH 2/2] net/i40e: fix blocking link wait on device start Ciara Loftus
2026-06-09 10:22 ` Bruce Richardson
2026-06-09 13:13 ` [PATCH 0/2] net/intel: " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603143407.1108527-2-ciara.loftus@intel.com \
--to=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox