From: Stephen Hemminger <stephen@networkplumber.org>
To: Denis Sergeev <denserg.edu@gmail.com>
Cc: dev@dpdk.org, chaoyong.he@corigine.com, stable@dpdk.org,
sdl.dpdk@linuxtesting.org
Subject: Re: [PATCH] net/nfp: fix null dereference in flower ctrl NFD3 Tx
Date: Mon, 8 Jun 2026 08:30:22 -0700 [thread overview]
Message-ID: <20260608083022.171d9f92@phoenix.local> (raw)
In-Reply-To: <20260603055211.120315-1-denserg.edu@gmail.com>
On Wed, 3 Jun 2026 08:51:56 +0300
Denis Sergeev <denserg.edu@gmail.com> wrote:
> In nfp_flower_ctrl_vnic_nfd3_xmit(), when txq is NULL, goto xmit_end
> leads to unconditional dereference of txq->qcp_q in nfp_qcp_ptr_add().
> The same goto from the "no free descriptors" path incorrectly increments
> the hardware write pointer despite no descriptor being written.
>
> Replace both gotos with early return, removing the unused xmit_end label.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: a36634e87e16 ("net/nfp: add flower ctrl VNIC Rx/Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Denis Sergeev <denserg.edu@gmail.com>
Applied to next-net
prev parent reply other threads:[~2026-06-08 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 5:51 [PATCH] net/nfp: fix null dereference in flower ctrl NFD3 Tx Denis Sergeev
2026-06-08 15:30 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608083022.171d9f92@phoenix.local \
--to=stephen@networkplumber.org \
--cc=chaoyong.he@corigine.com \
--cc=denserg.edu@gmail.com \
--cc=dev@dpdk.org \
--cc=sdl.dpdk@linuxtesting.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox