From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 189FDCD98ED for ; Wed, 17 Jun 2026 08:16:44 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F52C40ED2; Wed, 17 Jun 2026 10:15:25 +0200 (CEST) Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by mails.dpdk.org (Postfix) with ESMTP id 2B82140B94; Wed, 17 Jun 2026 10:15:22 +0200 (CEST) X-QQ-mid: zesmtpgz4t1781684119tfbd15f9a X-QQ-Originating-IP: 2L1RNlIk9wRzwX4Sjj/4jAt/pjlL+xqxDSO3XiJRANQ= Received: from DSK-zaiyuwang.trustnetic.com ( [183.157.22.210]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 17 Jun 2026 16:15:18 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 16091649717721759701 EX-QQ-RecipientCnt: 4 From: Zaiyu Wang To: dev@dpdk.org Cc: Zaiyu Wang , stable@dpdk.org, Jiawen Wu Subject: [PATCH v8 17/21] net/txgbe: fix get module info operation Date: Wed, 17 Jun 2026 16:13:04 +0800 Message-Id: <20260617081309.19124-18-zaiyuwang@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20260617081309.19124-1-zaiyuwang@trustnetic.com> References: <20260423034024.14404-1-zaiyuwang@trustnetic.com> <20260617081309.19124-1-zaiyuwang@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:trustnetic.com:qybglogicsvrsz:qybglogicsvrsz3b-0 X-QQ-XMAILINFO: OfsJkCxS1bGrBn0PeHNaT6fObdDEdchcf38qmCjn1+U1sncCs8WXRHVY ln2tRSs2QZRe6DnWe+MqL75X7JHIbrQIf8EqKw9FDJkMlwRDuH660dkLnH9Y+5O0t+p4YVF itLtU2TNuOyQRF+xpMKRjZQ7Uxnyw2DON7Bf0fNohswiiVICuHWkomUIegmvIsDAtPncasg FVOeYsRA4aV23PKaMtvpqp1ZP8e7S0t+xRggAHxLl78ftv7/i96dFx3xSxatoYc/fxqbiOS w+zUpIdMZLYVVHvkQ2tnFMSEUArJ/M6NZr5M4Fyr72AbuPZIKhCxrOrIN82UdioNz+fkULv n7zoQ5/l5PftmoYCVllNFiEaZXdQOYFS0LNCi1p/oj3zU5uvyzZgyHTcBQSyz45W/GzI3v1 /xZm5c6m7X6gDcGLKFGOwvDS7fcsq6j4pH/U98oFz3JSWY8yDl5XgjbtewqFLHedEhP9Beo SattMgZH19rLbhXre+IIHo882yiaqtwYEU5a20D5dUERZDpBNvcZY1uHwUdilgCM+fDt2Es 1IlVjs2W/qsa//EgUKFYrDR+rfC3kldTVaq4uQr29jquUFC/XHo0f7RTI7478nsSfziVmEB bq+LKFXgH44yrrRI+94OsvvAuSlO5ucmL3YGvhbPYg5u/DA0saZr8fXVCaHzjB+UnTaQfK9 mHklctAdCHppujGZf/kC1lPim975/jQFAtZtB+wkA1nJBRKvd2POddK71sZWnMCAHfe4xXL mKA1thCrT5jzlTPlIPpG6iNccKkgm0ucjTAP6Y8O5rCN9hJYybEiuzljPr0lYkVDJNLkVHw YMHnpIkeEKjRcP9khrUQzAw1f2VYIFJau04zxSxuhGrcYtJ3d/usC2gjPMfcGKp4tKvSdw0 JlgaKnem6np/5vcSyGPd+/s25GmEQlIjII93ijCqD/OEv31A+Q98kxBOjqLehMsCeiiebzO /ukH69Ec6Rd4ENOUTzKqV8FDfp+yOEZR0x3+SwzaOohXlgRCG2gnmY72gVbrmFcQZ88LR3O UH+GFjY7c29xbQx4Egs4FXDw/ZFIDpJ4RGUrLsgEdcVJgTthJqOa+5NrW4DlkCMlMzgZAaN LtnVNQEpVYa X-QQ-XMRINFO: MPJ6Tf5t3I/ylTmHUqvI8+Wpn+Gzalws3A== X-QQ-RECHKSPAM: 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The original I2C access flow in the module information retrieval process was flawed. Correct the implementation to properly fetch module info. Fixes: abf042d32b39 ("net/txgbe: add Amber-Lite 25G/40G NICs") Cc: stable@dpdk.org Signed-off-by: Zaiyu Wang --- drivers/net/txgbe/base/txgbe_phy.h | 6 +- drivers/net/txgbe/txgbe_ethdev.c | 118 +++++++++++++++++++++++------ 2 files changed, 98 insertions(+), 26 deletions(-) diff --git a/drivers/net/txgbe/base/txgbe_phy.h b/drivers/net/txgbe/base/txgbe_phy.h index 20c80d9d88..31bdceb35b 100644 --- a/drivers/net/txgbe/base/txgbe_phy.h +++ b/drivers/net/txgbe/base/txgbe_phy.h @@ -258,10 +258,14 @@ #define TXGBE_SFF_CABLE_DA_ACTIVE 0x8 #define TXGBE_SFF_CABLE_SPEC_COMP 0x3C #define TXGBE_SFF_SFF_8472_SWAP 0x5C +#define TXGBE_SFF_DDM_IMPLEMENTED 0x40 #define TXGBE_SFF_SFF_8472_COMP 0x5E #define TXGBE_SFF_SFF_8472_OSCB 0x6E #define TXGBE_SFF_SFF_8472_ESCB 0x76 -#define TXGBE_SFF_QSFP_PAGE_SELECT 0x7F +#define TXGBE_SFF_SFF_REVISION_ADDR 0x01 +#define TXGBE_SFF_QSFP_PAGE_SELECT 0x7F + +#define TXGBE_MODULE_QSFP_MAX_LEN 640 #define TXGBE_SFF_IDENTIFIER_QSFP 0x0C #define TXGBE_SFF_IDENTIFIER_QSFP_PLUS 0x0D diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 9f7d8e8a31..c0471e3d0f 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -5348,41 +5348,109 @@ txgbe_get_module_info(struct rte_eth_dev *dev, struct txgbe_hw *hw = TXGBE_DEV_HW(dev); uint32_t status; uint8_t sff8472_rev, addr_mode; + uint8_t identifier; + uint8_t sff8636_rev; bool page_swap = false; + uint32_t value; - /* Check whether we support SFF-8472 or not */ - status = hw->phy.read_i2c_eeprom(hw, - TXGBE_SFF_SFF_8472_COMP, - &sff8472_rev); - if (status != 0) - return -EIO; + if (hw->mac.type == txgbe_mac_aml40) { + value = rd32(hw, TXGBE_GPIOEXT); + if (value & TXGBE_SFP1_MOD_PRST_LS) { + PMD_DRV_LOG(WARNING, "QSFP module not present, cannot get module info."); + return -EINVAL; + } + } + + if (hw->mac.type == txgbe_mac_aml) { + value = rd32(hw, TXGBE_GPIOEXT); + if (value & TXGBE_SFP1_MOD_ABS_LS) { + PMD_DRV_LOG(WARNING, "SFP module not present, cannot get module info."); + return -EINVAL; + } + } - /* addressing mode is not supported */ - status = hw->phy.read_i2c_eeprom(hw, - TXGBE_SFF_SFF_8472_SWAP, - &addr_mode); + status = hw->mac.acquire_swfw_sync(hw, TXGBE_MNGSEM_SWPHY); if (status != 0) - return -EIO; + return -EBUSY; - if (addr_mode & TXGBE_SFF_ADDRESSING_MODE) { - PMD_DRV_LOG(ERR, - "Address change required to access page 0xA2, " - "but not supported. Please report the module " - "type to the driver maintainers."); - page_swap = true; + if (hw->mac.type == txgbe_mac_aml40) { + status = hw->phy.read_i2c_sff8636(hw, 0, + TXGBE_SFF_IDENTIFIER, + &identifier); + } else { + status = hw->phy.read_i2c_eeprom(hw, + TXGBE_SFF_IDENTIFIER, + &identifier); } - if (sff8472_rev == TXGBE_SFF_SFF_8472_UNSUP || page_swap) { - /* We have a SFP, but it does not support SFF-8472 */ - modinfo->type = RTE_ETH_MODULE_SFF_8079; - modinfo->eeprom_len = RTE_ETH_MODULE_SFF_8079_LEN; - } else { - /* We have a SFP which supports a revision of SFF-8472. */ - modinfo->type = RTE_ETH_MODULE_SFF_8472; - modinfo->eeprom_len = RTE_ETH_MODULE_SFF_8472_LEN; + if (status != 0) + goto ERROR_IO; + + switch (identifier) { + case TXGBE_SFF_IDENTIFIER_SFP: + /* Check whether we support SFF-8472 or not */ + status = hw->phy.read_i2c_eeprom(hw, + TXGBE_SFF_SFF_8472_COMP, + &sff8472_rev); + if (status != 0) + goto ERROR_IO; + + /* addressing mode is not supported */ + status = hw->phy.read_i2c_eeprom(hw, + TXGBE_SFF_SFF_8472_SWAP, + &addr_mode); + if (status != 0) + goto ERROR_IO; + + if (addr_mode & TXGBE_SFF_ADDRESSING_MODE) { + PMD_DRV_LOG(ERR, + "Address change required to access page 0xA2, " + "but not supported. Please report the module " + "type to the driver maintainers."); + page_swap = true; + } + + if (sff8472_rev == TXGBE_SFF_SFF_8472_UNSUP || page_swap || + !(addr_mode & TXGBE_SFF_DDM_IMPLEMENTED)) { + /* We have a SFP, but it does not support SFF-8472 */ + modinfo->type = RTE_ETH_MODULE_SFF_8079; + modinfo->eeprom_len = RTE_ETH_MODULE_SFF_8079_LEN; + } else { + /* We have a SFP which supports a revision of SFF-8472. */ + modinfo->type = RTE_ETH_MODULE_SFF_8472; + modinfo->eeprom_len = RTE_ETH_MODULE_SFF_8472_LEN; + } + break; + case TXGBE_SFF_IDENTIFIER_QSFP: + case TXGBE_SFF_IDENTIFIER_QSFP_PLUS: + status = hw->phy.read_i2c_sff8636(hw, 0, + TXGBE_SFF_SFF_REVISION_ADDR, + &sff8636_rev); + if (status != 0) + goto ERROR_IO; + /* Check revision compliance */ + if (sff8636_rev > 0x02) { + /* Module is SFF-8636 compliant */ + modinfo->type = RTE_ETH_MODULE_SFF_8636; + modinfo->eeprom_len = TXGBE_MODULE_QSFP_MAX_LEN; + } else { + modinfo->type = RTE_ETH_MODULE_SFF_8436; + modinfo->eeprom_len = TXGBE_MODULE_QSFP_MAX_LEN; + } + break; + default: + PMD_DRV_LOG(ERR, "SFF Module Type not recognized, identifier=0x%x", identifier); + hw->mac.release_swfw_sync(hw, TXGBE_MNGSEM_SWPHY); + return -EINVAL; } + hw->mac.release_swfw_sync(hw, TXGBE_MNGSEM_SWPHY); return 0; + +ERROR_IO: + PMD_DRV_LOG(ERR, "I2C IO ERROR."); + hw->mac.release_swfw_sync(hw, TXGBE_MNGSEM_SWPHY); + return -EIO; } static int -- 2.21.0.windows.1