DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: stephen@networkplumber.org, david.marchand@redhat.com, dev@dpdk.org
Cc: stable@dpdk.org
Subject: [PATCH v2 01/18] bus/dpaa: fix error handling of qman_create_fq
Date: Fri, 19 Jun 2026 11:38:59 +0530	[thread overview]
Message-ID: <20260619060916.485258-2-hemant.agrawal@nxp.com> (raw)
In-Reply-To: <20260619060916.485258-1-hemant.agrawal@nxp.com>

Fix the error handling path in qman_create_fq() to properly
return error codes instead of silently ignoring failures.

Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/bus/dpaa/base/qbman/qman.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c
index 5534e1846c..9a99eb9785 100644
--- a/drivers/bus/dpaa/base/qbman/qman.c
+++ b/drivers/bus/dpaa/base/qbman/qman.c
@@ -1579,6 +1579,9 @@ int qman_create_fq(u32 fqid, u32 flags, struct qman_fq *fq)
 err:
 	if (flags & QMAN_FQ_FLAG_DYNAMIC_FQID)
 		qman_release_fqid(fqid);
+#ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
+	clear_fq_table_entry(fq->key);
+#endif
 	return -EIO;
 }
 
-- 
2.43.0


  reply	other threads:[~2026-06-19  6:09 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 14:11 [PATCH v1 00/17] net/dpaa: bug fixes for bus, net and fmlib drivers Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 01/17] bus/dpaa: fix error handling of qman_create_fq Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 02/17] bus/dpaa: fix fqid endianness Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 03/17] bus/dpaa: fix error handling in qman_query Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 04/17] net/dpaa: fix modify cgr to use index Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 05/17] net/dpaa/fmlib: add null check in scheme delete Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 06/17] bus/dpaa: fix BMI RX stats register offset Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 07/17] bus/dpaa: fix fd leak for ccsr mmap Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 08/17] bus/dpaa: fix device probe issue Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 09/17] net/dpaa: fix device remove Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 10/17] net/dpaa: fix invalid check on interrupt unregister Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 11/17] net/dpaa: fix coverity reported issues Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 12/17] net/dpaa: fix xstat name for tx undersized counter Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 13/17] net/dpaa: fix xstat string typos in BMI stats table Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 14/17] net/dpaa: remove duplicate ptype entries Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 15/17] net/dpaa: fix wrong buffer in xstats get by id Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 16/17] net/dpaa: fix null l3_len check in checksum offload Hemant Agrawal
2026-06-18 14:11 ` [PATCH v1 17/17] net/dpaa: fix mbuf leak in SG fd creation Hemant Agrawal
2026-06-18 15:56 ` [PATCH v1 00/17] net/dpaa: bug fixes for bus, net and fmlib drivers Stephen Hemminger
2026-06-19  6:08 ` [PATCH v2 00/18] " Hemant Agrawal
2026-06-19  6:08   ` Hemant Agrawal [this message]
2026-06-19  6:09   ` [PATCH v2 02/18] bus/dpaa: fix fqid endianness Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 03/18] bus/dpaa: fix error handling in qman_query Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 04/18] net/dpaa: fix modify cgr to use index Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 05/18] net/dpaa/fmlib: add null check in scheme delete Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 06/18] bus/dpaa: fix BMI RX stats register offset Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 07/18] bus/dpaa: fix fd leak for ccsr mmap Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 08/18] bus/dpaa: fix device probe issue Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 09/18] net/dpaa: fix device remove Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 10/18] net/dpaa: fix invalid check on interrupt unregister Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 11/18] net/dpaa: fix port_handle leak in fm_prev_cleanup Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 12/18] dma/dpaa: fix out-of-bounds access in SG descriptor enqueue Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 13/18] net/dpaa: fix xstat name for tx undersized counter Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 14/18] net/dpaa: fix xstat string typos in BMI stats table Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 15/18] net/dpaa: remove duplicate ptype entries Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 16/18] net/dpaa: fix wrong buffer in xstats get by id Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 17/18] net/dpaa: fix null l3_len check in checksum offload Hemant Agrawal
2026-06-19  6:09   ` [PATCH v2 18/18] net/dpaa: fix mbuf leak in SG fd creation Hemant Agrawal
2026-06-19 10:38   ` [PATCH v3 00/18] net/dpaa: bug fixes for bus, net and fmlib drivers Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 01/18] bus/dpaa: fix error handling of qman_create_fq Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 02/18] bus/dpaa: fix fqid endianness Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 03/18] bus/dpaa: fix error handling in qman_query Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 04/18] net/dpaa: fix modify cgr to use index Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 05/18] net/dpaa/fmlib: add null check in scheme delete Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 06/18] bus/dpaa: fix BMI RX stats register offset Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 07/18] bus/dpaa: fix fd leak for ccsr mmap Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 08/18] bus/dpaa: fix device probe issue Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 09/18] net/dpaa: fix device remove Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 10/18] net/dpaa: fix invalid check on interrupt unregister Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 11/18] net/dpaa: fix port_handle leak in fm_prev_cleanup Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 12/18] dma/dpaa: fix out-of-bounds access in SG descriptor enqueue Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 13/18] net/dpaa: fix xstat name for tx undersized counter Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 14/18] net/dpaa: fix xstat string typos in BMI stats table Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 15/18] net/dpaa: remove duplicate ptype entries Hemant Agrawal
2026-06-19 10:38     ` [PATCH v3 16/18] net/dpaa: fix wrong buffer in xstats get by id Hemant Agrawal
2026-06-19 10:39     ` [PATCH v3 17/18] net/dpaa: fix null l3_len check in checksum offload Hemant Agrawal
2026-06-19 10:39     ` [PATCH v3 18/18] net/dpaa: fix mbuf leak in SG fd creation Hemant Agrawal
2026-06-19 17:28     ` [PATCH v3 00/18] net/dpaa: bug fixes for bus, net and fmlib drivers Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260619060916.485258-2-hemant.agrawal@nxp.com \
    --to=hemant.agrawal@nxp.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox