From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94427CD98F2 for ; Fri, 19 Jun 2026 12:29:55 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 879CB40E1D; Fri, 19 Jun 2026 14:29:34 +0200 (CEST) Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by mails.dpdk.org (Postfix) with ESMTP id 0D08540E13 for ; Fri, 19 Jun 2026 14:29:32 +0200 (CEST) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id E3D731A014F; Fri, 19 Jun 2026 14:29:31 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id AE6131A025D; Fri, 19 Jun 2026 14:29:31 +0200 (CEST) Received: from lsv03583.swis.in-blr01.nxp.com (lsv03583.swis.in-blr01.nxp.com [92.120.146.12]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 3095E180004C; Fri, 19 Jun 2026 20:29:30 +0800 (+08) From: Hemant Agrawal To: stephen@networkplumber.org, david.marchand@redhat.com, dev@dpdk.org Cc: Prashant Gupta Subject: [PATCH 04/18] dpaa: add process-type guards to prevent segfaults in secondary Date: Fri, 19 Jun 2026 17:59:01 +0530 Message-Id: <20260619122922.3774666-5-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260619122922.3774666-1-hemant.agrawal@nxp.com> References: <20260619122922.3774666-1-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Prashant Gupta Add RTE_PROC_PRIMARY checks in device initialization paths for net/dpaa, crypto/dpaa_sec and dma/dpaa drivers. Secondary processes should skip hardware initialization to prevent segfaults when accessing hardware registers that are only mapped in the primary process. Signed-off-by: Prashant Gupta --- drivers/crypto/dpaa_sec/dpaa_sec.c | 3 --- drivers/dma/dpaa/dpaa_qdma.c | 4 ++++ drivers/net/dpaa/dpaa_ethdev.c | 3 +++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 65bbd38b17..36f5819b0e 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -3783,9 +3783,6 @@ cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, RTE_DPAA_MAX_NB_SEC_QPS, }; - if (rte_eal_process_type() != RTE_PROC_PRIMARY) - return 0; - snprintf(cryptodev_name, sizeof(cryptodev_name), "%s", dpaa_dev->name); cryptodev = rte_cryptodev_pmd_create(cryptodev_name, &dpaa_dev->device, &init_params); diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c index b20ff24ab6..bf2a373d70 100644 --- a/drivers/dma/dpaa/dpaa_qdma.c +++ b/drivers/dma/dpaa/dpaa_qdma.c @@ -1334,6 +1334,10 @@ dpaa_qdma_init(struct rte_dma_dev *dmadev) int regs_size; int ret; uint32_t i, j, k; + char *penv; + + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return -ENOTSUP; if (dpaa_get_devargs(dmadev->device->devargs, DPAA_DMA_ERROR_CHECK)) { s_hw_err_check = true; diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index ebd50d340d..70d1e9acc3 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -2685,6 +2685,9 @@ rte_dpaa_remove(struct rte_dpaa_device *dpaa_dev) PMD_INIT_FUNC_TRACE(); + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return 0; + eth_dev = dpaa_dev->eth_dev; if (eth_dev->state != RTE_ETH_DEV_UNUSED) { dpaa_eth_dev_close(eth_dev); -- 2.25.1