Re: [PATCH 1/5] eal: fix macro for versioned experimental symbol

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 23 Jun 2026 17:26:22 +0200
Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:

> On Tue, Jun 23, 2026 at 06:50:00AM -0700, Stephen Hemminger wrote:
> > On Tue, 23 Jun 2026 13:37:47 +0200
> > Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
> >   
> > > Add a missing semicolon after __asm__ block in
> > > RTE_VERSION_EXPERIMENTAL_SYMBOL macro.
> > > It's lack triggers the following compilation error with clang:
> > > 
> > >     ../lib/ethdev/rte_flow.c:320:1: error: expected ';' after top-level asm block
> > >       320 | RTE_VERSION_EXPERIMENTAL_SYMBOL(int, rte_flow_dynf_metadata_register, (void))
> > >           | ^
> > >     ../lib/eal/common/eal_export.h:75:74: note: expanded from macro 'RTE_VERSION_EXPERIMENTAL_SYMBOL'
> > >        75 | __asm__(".symver " RTE_STR(name) "_exp, " RTE_STR(name) "@EXPERIMENTAL") \
> > >           |                                                                          ^
> > >     ../lib/eal/include/rte_common.h:237:20: note: expanded from macro '\
> > >     __rte_used'
> > >       237 | #define __rte_used __attribute__((used))
> > >           |                    ^
> > > 
> > > Fixes: e30e194c4d06 ("eal: rework function versioning macros")
> > > Cc: david.marchand@redhat.com
> > > 
> > > Signed-  
> > 
> > I didn't see this because clang doesn't have symver support.
> > Which version of clang is this?  
> 
> clang 19 available on Debian 13:
> 
>   $ clang --version
>   Debian clang version 19.1.7 (3+b1)
>   Target: x86_64-pc-linux-gnu
>   Thread model: posix
>   InstalledDir: /usr/lib/llvm-19/bin

Ok, that was the asm block not the symver attribute.