From: Stephen Hemminger <stephen@networkplumber.org>
To: Dawid Wesierski <dawid.wesierski@intel.com>
Cc: dev@dpdk.org, marek.kasiewicz@intel.com, thomas@monjalon.net,
mb@smartsharesystems.com
Subject: Re: [PATCH v5] pcapng: add user-supplied timestamp support
Date: Wed, 24 Jun 2026 15:07:34 -0700 [thread overview]
Message-ID: <20260624150734.4311e330@phoenix.local> (raw)
In-Reply-To: <20260624215858.710217-1-dawid.wesierski@intel.com>
On Wed, 24 Jun 2026 17:57:01 -0400
Dawid Wesierski <dawid.wesierski@intel.com> wrote:
> + /*
> + * Use caller provided timestamp.
> + * If none provided, use current TSC and set flag.
> + */
> + if (timestamp == 0)
> + timestamp = rte_get_tsc_cycles() | PCAPNG_TSC_FLAG;
> +
If you are going to use high bit as flag, then probably need to
enforce that that bit is not set on input from user.
next prev parent reply other threads:[~2026-06-24 22:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 14:38 [PATCH v3 1/1] pcapng: add user-supplied timestamp support Dawid Wesierski
2026-06-18 15:22 ` Stephen Hemminger
2026-06-18 16:45 ` Morten Brørup
2026-06-18 18:51 ` Stephen Hemminger
2026-06-23 14:10 ` [PATCH v4] " Dawid Wesierski
2026-06-23 13:53 ` Stephen Hemminger
2026-06-24 21:57 ` [PATCH v5] " Dawid Wesierski
2026-06-24 22:07 ` Stephen Hemminger [this message]
2026-06-24 22:17 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260624150734.4311e330@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dawid.wesierski@intel.com \
--cc=dev@dpdk.org \
--cc=marek.kasiewicz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox