DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: samar yadav <samaryadav5@gmail.com>
To: stephen@networkplumber.org
Cc: chenbox@nvidia.com, dev@dpdk.org, maxime.coquelin@redhat.com,
	samaryadav5@gmail.com, stable@dpdk.org, tiwei.bie@intel.com
Subject: Re: [PATCH] net/virtio-user: fix eventfd sharing in secondary process
Date: Fri, 26 Jun 2026 08:04:15 +0000	[thread overview]
Message-ID: <20260626080415.2370845-1-ysamar@vmware.com> (raw)
In-Reply-To: <20260624081036.6c6c82e8@phoenix.local>

On Wed, 24 Jun 2026 08:10:36 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> > +	pp = rte_zmalloc("virtio_user_proc_priv", sizeof(*pp), 0);
> > +	if (pp == NULL)
> > +		return -ENOMEM;
> > +
> > +	pp->kickfds = rte_malloc("virtio_user_proc_priv",
> > +				 total_queues * sizeof(int), 0);
> > +	pp->callfds = rte_malloc("virtio_user_proc_priv",
> > +				 total_queues * sizeof(int), 0);
>
> Better to use rte_calloc.

Agreed Stephen, will switch to rte_calloc in patch v2:

-	pp->kickfds = rte_malloc("virtio_user_proc_priv",
-				 total_queues * sizeof(int), 0);
-	pp->callfds = rte_malloc("virtio_user_proc_priv",
-				 total_queues * sizeof(int), 0);
+	pp->kickfds = rte_calloc("virtio_user_proc_priv",
+				 total_queues, sizeof(int), 0);
+	pp->callfds = rte_calloc("virtio_user_proc_priv",
+				 total_queues, sizeof(int), 0);


Samar Yadav

  parent reply	other threads:[~2026-06-28 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  8:57 [PATCH] net/virtio-user: fix eventfd sharing in secondary process Samar Yadav
2026-06-24 15:10 ` Stephen Hemminger
2026-06-26  7:41   ` Samar Yadav
2026-06-26  8:04   ` samar yadav [this message]
2026-06-24 15:16 ` Stephen Hemminger
2026-06-26  7:37   ` Samar Yadav
2026-06-26  8:05   ` samar yadav
2026-06-29 12:06     ` [PATCH v2] " Samar Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260626080415.2370845-1-ysamar@vmware.com \
    --to=samaryadav5@gmail.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox