From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Jie Liu <liujie5@linkdatatechnology.com>
Subject: [PATCH 1/2] net/sxe2: replace memcpy with structure assignment
Date: Tue, 28 Jul 2026 07:37:59 -0700 [thread overview]
Message-ID: <20260728143800.148509-1-stephen@networkplumber.org> (raw)
When possible prefer structure assigment over untyped memcpy.
Found by cocci/struct-assign.cocci script.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/sxe2/sxe2_flow.c | 7 +++----
drivers/net/sxe2/sxe2_ipsec.c | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/sxe2/sxe2_flow.c b/drivers/net/sxe2/sxe2_flow.c
index 63cfc36968..6c2e743f30 100644
--- a/drivers/net/sxe2/sxe2_flow.c
+++ b/drivers/net/sxe2/sxe2_flow.c
@@ -416,7 +416,7 @@ static int32_t sxe2_flow_src_split_proc(struct rte_eth_dev *dev,
ret = -ENOMEM;
goto l_end;
}
- rte_memcpy(flow_new, flow, sizeof(struct sxe2_flow));
+ *flow_new = *flow;
TAILQ_INSERT_TAIL(sxe2_flow_list, flow_new, next);
flow_new->meta.flow_src_vsi =
flow_src_vsi[SXE2_MAX_DRV_TYPE_DPDK][idx];
@@ -437,7 +437,7 @@ static int32_t sxe2_flow_src_split_proc(struct rte_eth_dev *dev,
ret = -ENOMEM;
goto l_end;
}
- rte_memcpy(flow_new, flow, sizeof(struct sxe2_flow));
+ *flow_new = *flow;
TAILQ_INSERT_TAIL(sxe2_flow_list, flow_new, next);
flow_new->meta.flow_src_vsi =
flow_src_vsi[SXE2_MAX_DRV_TYPE_KERNEL][idx];
@@ -697,8 +697,7 @@ static int32_t sxe2_flow_tunnel_split_proc(struct rte_eth_dev *dev __rte_unused,
ret = -ENOMEM;
goto l_end;
}
- rte_memcpy(sxe2_flow_new, sxe2_flow_exist,
- sizeof(struct sxe2_flow));
+ *sxe2_flow_new = *sxe2_flow_exist;
pattern = &sxe2_flow_new->pattern_outer;
sxe2_flow_new->meta.tunnel_type =
SXE2_FLOW_TUNNEL_TYPE_GRE;
diff --git a/drivers/net/sxe2/sxe2_ipsec.c b/drivers/net/sxe2/sxe2_ipsec.c
index e783a51b85..81cf250fd2 100644
--- a/drivers/net/sxe2/sxe2_ipsec.c
+++ b/drivers/net/sxe2/sxe2_ipsec.c
@@ -1159,7 +1159,7 @@ int sxe2_ipsec_pkt_metadata_set(void *device, struct rte_security_session *sessi
md = RTE_MBUF_DYNFIELD(m, sxe2_sctx->ipsec_ctx.md_offset, struct sxe2_ipsec_pkt_metadata *);
- memcpy(md, &sxe2_sess->pkt_metadata_template, sizeof(struct sxe2_ipsec_pkt_metadata));
+ *md = sxe2_sess->pkt_metadata_template;
md->esp_head_offset = offset;
PMD_LOG_INFO(DRV, "ipsec metadata set, offset:%u, said:%u, mode:%u, algo:%u.", offset,
--
2.53.0
next reply other threads:[~2026-07-28 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 14:37 Stephen Hemminger [this message]
2026-07-28 14:38 ` [PATCH 2/2] net/ixgbe: replace memcpy with structure assignment Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728143800.148509-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liujie5@linkdatatechnology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox