From: Huisong Li <lihuisong@huawei.com>
To: <anatoly.burakov@intel.com>, <sivaprasad.tummala@amd.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>,
<stephen@networkplumber.org>, <fengchengwen@huawei.com>,
<yangxingui@huawei.com>, <zhanjie9@hisilicon.com>,
<lihuisong@huawei.com>
Subject: [PATCH v4 3/6] examples/l3fwd-power: fix uncore help and log info
Date: Wed, 29 Jul 2026 10:51:46 +0800 [thread overview]
Message-ID: <20260729025149.2158868-4-lihuisong@huawei.com> (raw)
In-Reply-To: <20260729025149.2158868-1-lihuisong@huawei.com>
The '-i' parameter is to set any uncore frequency rather than
min/max value. And the error logs are not clear enough, fix it
by the way.
Fixes: 10db2a5b8724 ("examples/l3fwd-power: add options for uncore frequency")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
doc/guides/sample_app_ug/l3_forward_power_man.rst | 2 +-
examples/l3fwd-power/main.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst b/doc/guides/sample_app_ug/l3_forward_power_man.rst
index f33f3b2f94..ef3f1f1519 100644
--- a/doc/guides/sample_app_ug/l3_forward_power_man.rst
+++ b/doc/guides/sample_app_ug/l3_forward_power_man.rst
@@ -106,7 +106,7 @@ where,
* -U: optional, sets uncore min/max frequency to maximum value.
-* -i (frequency index): optional, sets uncore frequency to frequency index value, by setting min and max values to be the same.
+* -i (frequency index): set target frequency for uncore by specified frequency index.
* --config (port,queue,lcore)[,(port,queue,lcore)]: determines which queues from which ports are mapped to which cores.
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 3af10c629a..72d4642ea4 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1497,7 +1497,7 @@ print_usage(const char *prgname)
" -P: enable promiscuous mode\n"
" -u: set min/max frequency for uncore to minimum value\n"
" -U: set min/max frequency for uncore to maximum value\n"
- " -i (frequency index): set min/max frequency for uncore to specified frequency index\n"
+ " -i (frequency index): set target frequency for uncore by specified frequency index\n"
" --config (port,queue,lcore): rx queues configuration\n"
" --eth-link-speed: force link speed\n"
" --cpu-resume-latency LATENCY: set CPU resume latency to control C-state selection,"
@@ -1581,7 +1581,7 @@ parse_uncore_options(enum uncore_choice choice, const char *argument)
ret = rte_power_uncore_freq_min(pkg, die);
if (ret == -1) {
RTE_LOG(INFO, L3FWD_POWER,
- "Unable to set the uncore min/max to minimum uncore frequency value for pkg %02u die %02u\n"
+ "Unable to set the uncore frequency to minimum value for pkg %02u die %02u\n"
, pkg, die);
return ret;
}
@@ -1589,7 +1589,7 @@ parse_uncore_options(enum uncore_choice choice, const char *argument)
ret = rte_power_uncore_freq_max(pkg, die);
if (ret == -1) {
RTE_LOG(INFO, L3FWD_POWER,
- "Unable to set uncore min/max to maximum uncore frequency value for pkg %02u die %02u\n"
+ "Unable to set uncore frequency to maximum value for pkg %02u die %02u\n"
, pkg, die);
return ret;
}
@@ -1610,7 +1610,7 @@ parse_uncore_options(enum uncore_choice choice, const char *argument)
ret = rte_power_set_uncore_freq(pkg, die, frequency_index);
if (ret == -1) {
RTE_LOG(INFO, L3FWD_POWER,
- "Unable to set min/max uncore index value for pkg %02u die %02u\n",
+ "Unable to set specified frequency index for pkg %02u die %02u\n",
pkg, die);
return ret;
}
--
2.33.0
next prev parent reply other threads:[~2026-07-29 2:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 2:51 [PATCH v4 0/6] power: uncore power improvements and auto-detection Huisong Li
2026-07-29 2:51 ` [PATCH v4 1/6] examples/l3fwd-power: fix uncore deinit for non-legacy Huisong Li
2026-07-29 2:51 ` [PATCH v4 2/6] examples/l3fwd-power: enable power QoS for all modes Huisong Li
2026-07-29 2:51 ` Huisong Li [this message]
2026-07-29 2:51 ` [PATCH v4 4/6] examples/l3fwd-power: relocate uncore initialization Huisong Li
2026-07-29 2:51 ` [PATCH v4 5/6] power: support automatic detection of uncore driver Huisong Li
2026-07-29 2:51 ` [PATCH v4 6/6] power: remove unused auto-detection uncore Huisong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729025149.2158868-4-lihuisong@huawei.com \
--to=lihuisong@huawei.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=sivaprasad.tummala@amd.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=yangxingui@huawei.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox