From: Stephen Hemminger <stephen@networkplumber.org>
To: "Bathija, Pravin" <Pravin.Bathija@dell.com>
Cc: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"fengchengwen@huawei.com" <fengchengwen@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [PATCH v2 1/1] vhost: tolerate file descriptor in REM_MEM_REG msg
Date: Fri, 31 Jul 2026 08:27:56 -0700 [thread overview]
Message-ID: <20260731082756.31f7a9d8@phoenix.local> (raw)
In-Reply-To: <IA0PPF659BD4C46C174C843A7FE6C0208C2F5C82@IA0PPF659BD4C46.namprd19.prod.outlook.com>
On Fri, 31 Jul 2026 08:19:07 +0000
"Bathija, Pravin" <Pravin.Bathija@dell.com> wrote:
> > > While the immediate motivation was libblkio, the spec's compatibility
> > > clause was written for exactly this situation — any front-end could
> > > make the same mistake. QEMU's libvhost-user reference implementation
> > already tolerates it (see vu_rem_mem_reg).
> >
> > Which does not change that I dislike such compat.
>
> I couldn't agree with you more. The libblkio fix is ready and will stop sending the fd.
> In an ideal world we'd fix libblkio and move on, but there are already several released versions
> of libblkio in the wild that exhibit this behavior. Users pairing those with a current DPDK will hit
> a broken connection with no obvious workaround.
IMHO security safety trumps the specification in this case.
Although it might help to document this somewhere and add a better message.
next prev parent reply other threads:[~2026-07-31 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 3:13 [PATCH v2 0/1] vhost: tolerate fd in REM_MEM_REG for interop pravin.bathija
2026-07-31 3:13 ` [PATCH v2 1/1] vhost: tolerate file descriptor in REM_MEM_REG msg pravin.bathija
2026-07-31 6:21 ` David Marchand
2026-07-31 7:07 ` Bathija, Pravin
2026-07-31 7:28 ` David Marchand
2026-07-31 8:19 ` Bathija, Pravin
2026-07-31 15:27 ` Stephen Hemminger [this message]
2026-07-31 17:15 ` Bathija, Pravin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731082756.31f7a9d8@phoenix.local \
--to=stephen@networkplumber.org \
--cc=Pravin.Bathija@dell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox