From: Stephen Hemminger <stephen@networkplumber.org>
To: Rita Ruvinsky <rita.ruvinsky@weka.io>
Cc: dev@dpdk.org, longli@microsoft.com, weh@microsoft.com, stable@dpdk.org
Subject: Re: [PATCH 1/2] net/mana: fix MR length truncation for chunks over 4GB
Date: Thu, 6 Aug 2026 10:02:35 -0700 [thread overview]
Message-ID: <20260806100235.63041357@phoenix.local> (raw)
In-Reply-To: <20260805154407.1965063-1-rita.ruvinsky@weka.io>
On Wed, 5 Aug 2026 18:44:06 +0300
Rita Ruvinsky <rita.ruvinsky@weka.io> wrote:
> mana_range.len is a uint32_t, so a mempool chunk of 4GB or more
> truncates modulo 2^32 -- exactly 4GB becomes 0, 15GB becomes 3GB.
>
> The guard against priv->max_mr_size cannot catch this because it
> compares the already-truncated value, and the device advertises
> max_mr_size as UINT64_MAX. ibv_reg_mr() then fails with EINVAL on a
> zero length, or silently registers a region far shorter than the pool,
> so lookups for buffers past that boundary never find an MR and no Rx
> WQE can be posted.
>
> Widen the length to uint64_t through the MR path, including the
> multi-process request that forwards it to the primary process.
>
> Fixes: 0f5db3c68ba7 ("net/mana: implement memory registration")
> Cc: stable@dpdk.org
> Signed-off-by: Rita Ruvinsky <rita.ruvinsky@weka.io>
> ---
This patch series will not build on main branch.
It has merge conflicts with recent device reset code.
prev parent reply other threads:[~2026-08-06 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 15:44 [PATCH 1/2] net/mana: fix MR length truncation for chunks over 4GB Rita Ruvinsky
2026-08-05 15:44 ` [PATCH 2/2] net/mana: fix double free of mbuf on Rx WQE post failure Rita Ruvinsky
2026-08-06 0:31 ` [EXTERNAL] " Long Li
2026-08-06 0:29 ` [EXTERNAL] [PATCH 1/2] net/mana: fix MR length truncation for chunks over 4GB Long Li
2026-08-06 17:02 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806100235.63041357@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=rita.ruvinsky@weka.io \
--cc=stable@dpdk.org \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox