From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7683C5B572 for ; Wed, 12 Aug 2026 17:09:16 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FD3340E2D; Wed, 12 Aug 2026 19:08:50 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id E356440B8D; Wed, 12 Aug 2026 19:08:46 +0200 (CEST) Received: from localhost.localdomain (unknown [78.109.70.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id 2C7B8E0C9E; Wed, 12 Aug 2026 21:08:46 +0400 (+04) DKIM-Filter: OpenDKIM Filter v2.11.0 agw.arknetworks.am 2C7B8E0C9E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arknetworks.am; s=default; t=1786554526; bh=CoRkKPdzIsmiPqS+CAQMyOH4WCIiR+tzEkWwyPmSiow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v61zvixawyc+yjMDLBbrnEoebljAel0TTqmFQ5vJxUhB43kIJ6xxUW+9JsE5WQ3UT 402IcfckIr70CZgFVrUeS9khEK7gxjwFyPdA5KGJOrCa/bq/5fRQ3nqh9ESMACCPvj yskszcK7iVQyBparkrxiA34WxhsxlczRhoM6kVmaUjKzaPlT4hI2c5Fvr7Gj2ibDUU NViuuXoOQdSnxNfb7oZO4BhoWMJECMxBXKOt7LZskBckyfkAoWHWmA9redvLewzx2H oe/Amen1ku9QUdc/sxplGGBPakK/4HrIPOBzAbfAG6HU8tnbFwV+Dq6ncthyMvjcBD RNO93YmkPmImg== From: Ivan Malov To: dev@dpdk.org Cc: Andy Moreton , Viacheslav Galaktionov , Roman Zhukov , Pieter Jansen van Vuuren , Stephen Hemminger , Andrew Rybchenko , stable@dpdk.org Subject: [PATCH v2 04/14] common/sfc_efx/base: reduce stack in netport stat describe Date: Wed, 12 Aug 2026 21:08:24 +0400 Message-ID: <20260812170834.8443-5-ivan.malov@arknetworks.am> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260812170834.8443-1-ivan.malov@arknetworks.am> References: <20260811174821.8930-1-ivan.malov@arknetworks.am> <20260812170834.8443-1-ivan.malov@arknetworks.am> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Andy Moreton Code analysis reports an error for excessive stack consumption (over 1KB). Use a heap allocated payload buffer instead. Fixes: f2f77453cb9f ("common/sfc_efx/base: fill in software LUT for MAC statistics") Cc: stable@dpdk.org Signed-off-by: Andy Moreton Reviewed-by: Ivan Malov Reviewed-by: Viacheslav Galaktionov --- drivers/common/sfc_efx/base/efx_np.c | 37 +++++++++++++++++++--------- 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/drivers/common/sfc_efx/base/efx_np.c b/drivers/common/sfc_efx/base/efx_np.c index 45f3cd07ed..5044eabdd3 100644 --- a/drivers/common/sfc_efx/base/efx_np.c +++ b/drivers/common/sfc_efx/base/efx_np.c @@ -778,22 +778,30 @@ efx_np_stats_describe( __out_opt uint32_t *nprocessedp, __out_opt uint32_t *nstats_maxp) { - EFX_MCDI_DECLARE_BUF(payload, - MC_CMD_MAC_STATISTICS_DESCRIPTOR_IN_LEN, - MC_CMD_MAC_STATISTICS_DESCRIPTOR_OUT_LENMAX_MCDI2); + uint8_t *payload = NULL; uint32_t nprocessed; efx_mcdi_req_t req; uint8_t *entries; uint32_t stride; unsigned int i; size_t out_sz; + size_t size; efx_rc_t rc; - req.emr_out_length = MC_CMD_MAC_STATISTICS_DESCRIPTOR_OUT_LENMAX_MCDI2; - req.emr_in_length = MC_CMD_MAC_STATISTICS_DESCRIPTOR_IN_LEN; + size = MAX(MC_CMD_MAC_STATISTICS_DESCRIPTOR_IN_LEN, + MC_CMD_MAC_STATISTICS_DESCRIPTOR_OUT_LENMAX_MCDI2); + + EFSYS_KMEM_ALLOC(enp->en_esip, size, payload); + if (payload == NULL) { + rc = ENOMEM; + goto fail1; + } + req.emr_cmd = MC_CMD_MAC_STATISTICS_DESCRIPTOR; - req.emr_out_buf = payload; req.emr_in_buf = payload; + req.emr_in_length = MC_CMD_MAC_STATISTICS_DESCRIPTOR_IN_LEN; + req.emr_out_buf = payload; + req.emr_out_length = MC_CMD_MAC_STATISTICS_DESCRIPTOR_OUT_LENMAX_MCDI2; MCDI_IN_SET_DWORD(req, MAC_STATISTICS_DESCRIPTOR_IN_PORT_HANDLE, nph); MCDI_IN_SET_DWORD(req, MAC_STATISTICS_DESCRIPTOR_IN_OFFSET, req_ofst); @@ -802,13 +810,13 @@ efx_np_stats_describe( if (req.emr_rc != 0) { rc = req.emr_rc; - goto fail1; + goto fail2; } out_sz = req.emr_out_length_used; if (out_sz < MC_CMD_MAC_STATISTICS_DESCRIPTOR_OUT_LENMIN) { rc = EMSGSIZE; - goto fail2; + goto fail3; } if (nstats_maxp != NULL) { @@ -818,13 +826,13 @@ efx_np_stats_describe( } if (lut_nentries == 0 || lut == NULL || nprocessedp == NULL) - return (0); + goto out; stride = MCDI_OUT_DWORD(req, MAC_STATISTICS_DESCRIPTOR_OUT_ENTRY_SIZE); nprocessed = MC_CMD_MAC_STATISTICS_DESCRIPTOR_OUT_ENTRIES_NUM(out_sz); if (nprocessed == 0) { rc = EMSGSIZE; - goto fail3; + goto fail4; } entries = MCDI_OUT2(req, uint8_t, @@ -834,14 +842,19 @@ efx_np_stats_describe( efx_np_stat_describe(entries + i * stride, lut_nentries, lut); *nprocessedp = nprocessed; + +out: + EFSYS_KMEM_FREE(enp->en_esip, size, payload); + return (0); +fail4: + EFSYS_PROBE(fail4); fail3: EFSYS_PROBE(fail3); - fail2: EFSYS_PROBE(fail2); - + EFSYS_KMEM_FREE(enp->en_esip, size, payload); fail1: EFSYS_PROBE1(fail1, efx_rc_t, rc); return (rc); -- 2.47.3