From: Stephen Hemminger <stephen@networkplumber.org>
To: Joshua Washington <joshwash@google.com>
Cc: Reshma Pattan <reshma.pattan@intel.com>,
Chaoyong He <chaoyong.he@corigine.com>,
Julien Aube <julien_dpdk@jaube.fr>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Shai Brandes <shaibran@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Amit Bernstein <amitbern@amazon.com>,
Wajeeh Atrash <atrwajee@amazon.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Xingui Yang <yangxingui@huawei.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Praveen Shetty <praveen.shetty@intel.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Alok Prasad <palok@marvell.com>, Wenbo Cao <caowenbo@mucse.com>,
Rosen Xu <rosen.xu@altera.com>,
dev@dpdk.org
Subject: Re: [PATCH] eal: introduce division round up macro
Date: Wed, 12 Aug 2026 18:29:46 -0700 [thread overview]
Message-ID: <20260812182946.16d1e889@phoenix.local> (raw)
In-Reply-To: <20260812223017.2980190-1-joshwash@google.com>
On Wed, 12 Aug 2026 15:30:17 -0700
Joshua Washington <joshwash@google.com> wrote:
> A number of drivers define the DIV_ROUND_UP macro -- add it to
> RTE_COMMON so that other code looking to use that functionality doesn't
> have to re-define it.
>
> Replace usage of DIV_ROUND_UP in existing places with RTE_DIV_ROUND_UP.
>
> Signed-off-by: Joshua Washington <joshwash@google.com>
> ---
Makes sense, but this is the kind of change that is best done as a patch series
so that each driver vendor looks at their code; and if something is broken
only one change needs to be reverted. Make blast radius smaller
prev parent reply other threads:[~2026-08-13 1:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 22:30 [PATCH] eal: introduce division round up macro Joshua Washington
2026-08-13 1:29 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812182946.16d1e889@phoenix.local \
--to=stephen@networkplumber.org \
--cc=amitbern@amazon.com \
--cc=anatoly.burakov@intel.com \
--cc=atrwajee@amazon.com \
--cc=bharat@chelsio.com \
--cc=bruce.richardson@intel.com \
--cc=caowenbo@mucse.com \
--cc=chaoyong.he@corigine.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=evgenys@amazon.com \
--cc=fengchengwen@huawei.com \
--cc=jingjing.wu@intel.com \
--cc=joshwash@google.com \
--cc=julien_dpdk@jaube.fr \
--cc=palok@marvell.com \
--cc=praveen.shetty@intel.com \
--cc=reshma.pattan@intel.com \
--cc=rosen.xu@altera.com \
--cc=shaibran@amazon.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox