From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id C71DFC5DF66 for ; Sun, 16 Aug 2026 06:21:16 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB09040685; Sun, 16 Aug 2026 08:20:59 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 6A6E24067C for ; Sun, 16 Aug 2026 08:20:55 +0200 (CEST) Received: from localhost.localdomain (unknown [78.109.77.214]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id 4AC44E0CAD; Sun, 16 Aug 2026 10:20:54 +0400 (+04) DKIM-Filter: OpenDKIM Filter v2.11.0 agw.arknetworks.am 4AC44E0CAD DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arknetworks.am; s=default; t=1786861255; bh=djWQXJArhajkaE71RSD1Vk3+wkJw+asIdK6bA7KMIRI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b1p03hKPkvqXiA+N9cnfGWLdL+YpcOR85jZBEn2kShWHpn5AGJKFPx5CXCkS5T6AD u68SxhwYBYbeBQ2cAimoshbwvdaoipmwIUc/uvt2yJoQmSZHDAEzg1xb6K9ZYQhGuy hAHkNJXw8+iYa3g7WlGLVmDpZ/3TocqovHtJqbytdIg5LGB92d4EmkEMnPNT4G460/ 6uP3sZKMg7HsUZcEsytw/nupS52edyd5BGu0xnMig3btS6k/y+LzlHZk1FMZtD8Ji7 /vAUmnwVaU76bS8uenDL8/aq12YmlE06dlSca7e86nQpr7O4Pd1vQ4gifwkkMwqxsd DLUh5lHiy5pTw== From: Ivan Malov To: dev@dpdk.org Cc: Andy Moreton , Viacheslav Galaktionov , Roman Zhukov , Pieter Jansen van Vuuren , Stephen Hemminger , Andrew Rybchenko Subject: [PATCH v4 4/6] common/sfc_efx/base: deny tuning FCS and flow control to VFs Date: Sun, 16 Aug 2026 10:20:38 +0400 Message-ID: <20260816062040.15562-5-ivan.malov@arknetworks.am> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260816062040.15562-1-ivan.malov@arknetworks.am> References: <20260811175025.9019-1-ivan.malov@arknetworks.am> <20260816062040.15562-1-ivan.malov@arknetworks.am> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Medford4 VFs can configure MAC settings via the netport MCDI, but controlling FCS stripping and setting flow control mode are off limits. Express all this in code to allow the DPDK driver to start and forbid changes to FCS and flow control. For what it's worth, changing MTU is allowed on VFs, but the value must be less than or equal to the PF's MTU. Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx_np.c | 41 +++++++++++++++++++++++----- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/drivers/common/sfc_efx/base/efx_np.c b/drivers/common/sfc_efx/base/efx_np.c index 8853ce07c3..90d9ca7918 100644 --- a/drivers/common/sfc_efx/base/efx_np.c +++ b/drivers/common/sfc_efx/base/efx_np.c @@ -1573,6 +1573,7 @@ efx_np_mac_ctrl( __in efx_np_handle_t nph, __in const efx_np_mac_ctrl_t *mc) { + const efx_nic_cfg_t *encp = &enp->en_nic_cfg; EFX_MCDI_DECLARE_BUF(payload, MC_CMD_MAC_CTRL_IN_LEN, MC_CMD_MAC_CTRL_OUT_LEN); @@ -1596,9 +1597,19 @@ efx_np_mac_ctrl( if (mc->enmc_set_pdu_only != B_FALSE) goto skip_full_reconfigure; - cfg |= 1U << MC_CMD_MAC_CONFIG_OPTIONS_CFG_INCLUDE_FCS; - if (mc->enmc_include_fcs != B_FALSE) - flags |= 1U << MC_CMD_MAC_FLAGS_FLAG_INCLUDE_FCS; + /* Only PFs can control FCS stripping. */ + if (EFX_PCI_FUNCTION_IS_PF(encp)) { + cfg |= 1U << MC_CMD_MAC_CONFIG_OPTIONS_CFG_INCLUDE_FCS; + if (mc->enmc_include_fcs != B_FALSE) + flags |= 1U << MC_CMD_MAC_FLAGS_FLAG_INCLUDE_FCS; + } else if (mc->enmc_include_fcs != B_FALSE) { + /* + * Assume that FCS stripping being enabled is the driver's + * default expectation and deny disabling it to VFs. + */ + rc = ENOTSUP; + goto fail1; + } MCDI_IN_SET_DWORD(req, MAC_CTRL_IN_FLAGS, flags); @@ -1620,12 +1631,22 @@ efx_np_mac_ctrl( break; default: rc = EINVAL; - goto fail1; + goto fail2; } } - cfg |= 1U << MC_CMD_MAC_CONFIG_OPTIONS_CFG_FCNTL; - MCDI_IN_SET_DWORD(req, MAC_CTRL_IN_FCNTL, fcntl); + /* Only PFs can change flow control settings. */ + if (EFX_PCI_FUNCTION_IS_PF(encp)) { + cfg |= 1U << MC_CMD_MAC_CONFIG_OPTIONS_CFG_FCNTL; + MCDI_IN_SET_DWORD(req, MAC_CTRL_IN_FCNTL, fcntl); + } else if (fcntl != MC_CMD_FCNTL_AUTO) { + /* + * Assume that flow control auto-negotiation is the driver's + * default expectation and deny any attempts to override it. + */ + rc = ENOTSUP; + goto fail3; + } skip_full_reconfigure: MCDI_IN_SET_DWORD(req, MAC_CTRL_IN_V2_CONTROL_FLAGS, cfg); @@ -1634,11 +1655,17 @@ efx_np_mac_ctrl( if (req.emr_rc != 0) { rc = req.emr_rc; - goto fail2; + goto fail4; } return (0); +fail4: + EFSYS_PROBE(fail4); + +fail3: + EFSYS_PROBE(fail3); + fail2: EFSYS_PROBE(fail2); -- 2.47.3