DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Malov <ivan.malov@arknetworks.am>
To: dev@dpdk.org
Cc: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
	Roman Zhukov <Roman.Zhukov@arknetworks.am>,
	Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [PATCH 2/2] net/sfc: provide cached dev info to use in secondary process
Date: Thu, 20 Aug 2026 17:03:14 +0400	[thread overview]
Message-ID: <20260820130314.12251-3-ivan.malov@arknetworks.am> (raw)
In-Reply-To: <20260820130314.12251-1-ivan.malov@arknetworks.am>

Secondary process support in the 'test-pmd' application now requires that
the driver expose the 'dev_infos_get' method within that context. Use the
cached dev info from the primary process in order to meet the requirement.

Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
Reviewed-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>
---
 drivers/net/sfc/sfc.h        |  7 +++++++
 drivers/net/sfc/sfc_ethdev.c | 29 +++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+)

diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h
index 629578549f..9fcc8c9044 100644
--- a/drivers/net/sfc/sfc.h
+++ b/drivers/net/sfc/sfc.h
@@ -156,6 +156,13 @@ struct sfc_adapter_shared {
 	unsigned int			nb_repr_txq;
 
 	struct sfc_nic_dma_info		nic_dma_info;
+
+	/*
+	 * Snapshot of the 'sfc_dev_infos_get' output created by the primary
+	 * process attach path for the secondary process to use in its own
+	 * implementation of the 'dev_infos_get' method.
+	 */
+	struct rte_eth_dev_info		dev_info_cache;
 };
 
 /* Adapter process private data */
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 13619b4b9a..aa0e92b004 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -3163,7 +3163,22 @@ sfc_eth_dev_clear_ops(struct rte_eth_dev *dev)
 	sa->priv.dp_rx = NULL;
 }
 
+static int
+sfc_dev_infos_get_secondary(struct rte_eth_dev *dev,
+			    struct rte_eth_dev_info *dev_info)
+{
+	*dev_info = sfc_adapter_shared_by_eth_dev(dev)->dev_info_cache;
+
+	/*
+	 * The cache holds a stale primary-process device pointer;
+	 * restore the process-local one passed in by the caller.
+	 */
+	dev_info->device = dev->device;
+	return 0;
+}
+
 static const struct eth_dev_ops sfc_eth_dev_secondary_ops = {
+	.dev_infos_get			= sfc_dev_infos_get_secondary,
 	.dev_supported_ptypes_get	= sfc_dev_supported_ptypes_get,
 	.reta_query			= sfc_dev_rss_reta_query,
 	.rss_hash_conf_get		= sfc_dev_rss_hash_conf_get,
@@ -3443,6 +3458,20 @@ sfc_eth_dev_init(struct rte_eth_dev *dev, void *init_params)
 
 	sa->link_ev_need_poll = encp->enc_link_ev_need_poll;
 
+	/*
+	 * Pre-populate the dev info cache for the secondary process.
+	 * All prerequisites (probe, attach) are met at this point.
+	 * The 'sfc_dev_infos_get' helper always returns 0.
+	 *
+	 * Care to initialise the switch info and reset the device
+	 * pointer as it is going to be stale in the context of
+	 * the secondary process and it will have to fix it.
+	 */
+	sas->dev_info_cache.switch_info.domain_id =
+		RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID;
+	(void)sfc_dev_infos_get(dev, &sas->dev_info_cache);
+	sas->dev_info_cache.device = NULL;
+
 	sfc_adapter_unlock(sa);
 
 	sfc_log_init(sa, "done");
-- 
2.47.3


  parent reply	other threads:[~2026-08-20 13:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 13:03 [PATCH 0/2] net/sfc: fix and extend secondary process support Ivan Malov
2026-08-20 13:03 ` [PATCH 1/2] net/sfc: fix shared adapter pointer set in secondary process Ivan Malov
2026-08-21 19:09   ` Stephen Hemminger
2026-08-20 13:03 ` Ivan Malov [this message]
2026-08-21 19:10   ` [PATCH 2/2] net/sfc: provide cached dev info to use " Stephen Hemminger
2026-08-21 23:45 ` [PATCH v2 0/2] net/sfc: fix and extend secondary process support Ivan Malov
2026-08-21 23:45   ` [PATCH v2 1/2] net/sfc: fix shared adapter pointer set in secondary process Ivan Malov
2026-08-21 23:45   ` [PATCH v2 2/2] net/sfc: provide cached dev info to use " Ivan Malov
2026-08-22  0:06 ` [PATCH v3 0/2] net/sfc: fix and extend secondary process support Ivan Malov
2026-08-22  0:06   ` [PATCH v3 1/2] net/sfc: fix shared adapter pointer set in secondary process Ivan Malov
2026-08-22  0:06   ` [PATCH v3 2/2] net/sfc: provide cached dev info to use " Ivan Malov
2026-08-24 15:34     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260820130314.12251-3-ivan.malov@arknetworks.am \
    --to=ivan.malov@arknetworks.am \
    --cc=Roman.Zhukov@arknetworks.am \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=pieter.jansen-van-vuuren@amd.com \
    --cc=stephen@networkplumber.org \
    --cc=viacheslav.galaktionov@arknetworks.am \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox