Re: [PATCH v6 2/3] ethdev: skip VMDq pools unless configured

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 24 Aug 2026 18:24:29 +0200
David Marchand <david.marchand@redhat.com> wrote:

> On Mon, 24 Aug 2026 at 18:21, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Mon, 24 Aug 2026 13:42:06 +0200
> > David Marchand <david.marchand@redhat.com> wrote:
> >  
> > > The mac_addr_add API describes that only the 0 pool should be passed
> > > unless VMDq has been enabled, though there was no validation so far.
> > > Add such a check, then cleanup the MAC related operations (adding,
> > > removing, restoring).
> > >
> > > As a side effect, the net/cnxk does not need to manually reset the
> > > mac_pool_sel[] array.
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > > ---  
> >
> > Claude Fable AI review has some warnings.  
> 
> Enough bikeshedding please.
> I requested a merge one month ago and got ignored.
> 
> Those warnings below are pointless.
> 
> Thanks.

I was going to merge. Just wanted to post the current AI reviews
to make sure.