From: William Bland <blandwwa@gmail.com>
To: Changchun Ouyang <changchun.ouyang@intel.com>,
Huawei Xie <huawei.xhw@alibaba-inc.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, William Bland <blandwwa@gmail.com>
Subject: [PATCH 1/3] net: fix VLAN insert doc comment for shared-mbuf error code
Date: Mon, 24 Aug 2026 15:22:25 -0400 [thread overview]
Message-ID: <20260824192228.1197189-1-blandwwa@gmail.com> (raw)
The implementation returns -EINVAL when the mbuf is shared or
indirect, but the doc comment inaccurately stated -EPERM.
Fixes: c974021a5949 ("ether: add soft vlan encap/decap")
Signed-off-by: William Bland <blandwwa@gmail.com>
---
lib/net/rte_ether.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/net/rte_ether.h b/lib/net/rte_ether.h
index c9a0b536c3..cb10d8fb06 100644
--- a/lib/net/rte_ether.h
+++ b/lib/net/rte_ether.h
@@ -387,7 +387,8 @@ static inline int rte_vlan_strip(struct rte_mbuf *m)
* The packet mbuf.
* @return
* - 0: On success
- * -EPERM: mbuf is shared overwriting would be unsafe
+ * -EINVAL: overwriting would be unsafe because mbuf is shared or
+ * indirect, or mbuf's first segment is too short
* -ENOSPC: not enough headroom in mbuf
*/
static inline int rte_vlan_insert(struct rte_mbuf **m)
--
2.43.0
next reply other threads:[~2026-08-24 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 19:22 William Bland [this message]
2026-08-24 19:22 ` [PATCH 2/3] net: add VLAN insert function with a TPID argument William Bland
2026-08-24 19:22 ` [PATCH 3/3] net/af_packet: fix QinQ outer TPID on VLAN reinsertion William Bland
2026-08-24 20:59 ` [PATCH 1/3] net: fix VLAN insert doc comment for shared-mbuf error code Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824192228.1197189-1-blandwwa@gmail.com \
--to=blandwwa@gmail.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xhw@alibaba-inc.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox