From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14382C61DD3 for ; Tue, 1 Sep 2026 10:19:40 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6755D4068A; Tue, 1 Sep 2026 12:19:35 +0200 (CEST) Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by mails.dpdk.org (Postfix) with ESMTP id 26ADD4027E; Tue, 1 Sep 2026 12:19:33 +0200 (CEST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 057EA20001C; Tue, 1 Sep 2026 12:19:33 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id C455C20001F; Tue, 1 Sep 2026 12:19:32 +0200 (CEST) Received: from lsv03583.swis.in-blr01.nxp.com (lsv03583.swis.in-blr01.nxp.com [92.120.146.12]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 6892A180006C; Tue, 1 Sep 2026 18:19:31 +0800 (+08) From: Hemant Agrawal To: stephen@networkplumber.org, thomas@monjalon.net, dev@dpdk.org Cc: stable@dpdk.org, Gagandeep Singh Subject: [PATCH v15 01/23] net/dpaa: fix device remove Date: Tue, 1 Sep 2026 15:49:04 +0530 Message-Id: <20260901101926.1574209-2-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260901101926.1574209-1-hemant.agrawal@nxp.com> References: <20260820144312.3922316-1-hemant.agrawal@nxp.com> <20260901101926.1574209-1-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Gagandeep Singh Adds a check to not to close device if already closed. Fixes: 78ea4b4fcb52 ("bus/dpaa: improve cleanup") Cc: stable@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/dpaa/dpaa_ethdev.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 4463c56601..569de71d9b 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -2679,9 +2679,12 @@ rte_dpaa_remove(struct rte_dpaa_device *dpaa_dev) PMD_INIT_FUNC_TRACE(); eth_dev = rte_eth_dev_allocated(dpaa_dev->device.name); - ret = dpaa_eth_dev_close(eth_dev); - if (eth_dev->state != RTE_ETH_DEV_UNUSED) { - dpaa_eth_dev_close(eth_dev); + if (eth_dev && eth_dev->state != RTE_ETH_DEV_UNUSED) { + int close_ret = dpaa_eth_dev_close(eth_dev); + + if (close_ret) + DPAA_PMD_WARN("%s: close failed (%d), releasing port anyway", + dpaa_dev->device.name, close_ret); ret = rte_eth_dev_release_port(eth_dev); } dpaa_valid_dev--; -- 2.25.1