DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>, stable@dpdk.org
Subject: [PATCH] app/testpmd: fix stale queue-count check order
Date: Fri,  4 Sep 2026 13:38:42 +0000	[thread overview]
Message-ID: <20260904133842.3155785-1-ciara.loftus@intel.com> (raw)

Currently, when setting the number of queues via `port config all txq/rxq`,
testpmd validates the requested queue count against a device's current
queue-count limits, then rebuilds the forwarding stream configuration
before refreshing each port's cached device information. The forwarding
stream setup step re-checks the requested queue count against that cache,
so it can still reject a value that was just accepted if the cached
limits are older than the freshly queried ones.

This is not observable while a port's queue-count limits stay fixed
for its lifetime. It becomes visible whenever a PMD's reported
`max_rx_queues`/`max_tx_queues` change after the port was first probed,
for example when a driver recomputes queue capacity in response to a
traffic management (`rte_tm`) hierarchy commit. The stale cached values
then no longer match what the device currently reports, so a queue count
that is actually valid can be wrongly rejected.

Fix it by refreshing the cached device information before rebuilding
the forwarding stream configuration, so both checks operate on the same,
current queue-count limits.

Fixes: 0c0db76f42ed ("app/testpmd: separate forward config setup from display")
Cc: stable@dpdk.org

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 app/test-pmd/cmdline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 10ee7c5179..95a4ebfb96 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -2010,10 +2010,10 @@ cmd_config_rx_tx_parsed(void *parsed_result,
 		return;
 	}
 
-	fwd_config_setup();
-
 	init_port_config();
 
+	fwd_config_setup();
+
 	cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1);
 }
 
-- 
2.43.0


             reply	other threads:[~2026-09-04 13:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 13:38 Ciara Loftus [this message]
2026-09-04 16:41 ` [PATCH] app/testpmd: fix stale queue-count check order Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904133842.3155785-1-ciara.loftus@intel.com \
    --to=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox