From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A6FC79F89 for ; Mon, 7 Sep 2026 11:17:42 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98D0B40678; Mon, 7 Sep 2026 13:17:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 52F674067B for ; Mon, 7 Sep 2026 13:17:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788779857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a1zU44w7jy/iu0mbfS2hvR04og45NnHyhI6jHrWP/nw=; b=PH05M0zRrZu/SLCP7dcp8CRfeg2a+34GGwLBpSjDEtjE13waUH7ksBm37eHlzpz10ox1a+ 6QgwauOwvDyTJRR/Ik1BjCYkgul1g74y49tpnh8FGRNjX2JKWnKK1Bdbb8r/zN8TJuaR8M vpDHW0ZdH7gXM9b8J5xEJyVyaH1RJ04= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-GI9lXOB8PnOfH3OP2ai8xg-1; Mon, 07 Sep 2026 07:17:34 -0400 X-MC-Unique: GI9lXOB8PnOfH3OP2ai8xg-1 X-Mimecast-MFC-AGG-ID: GI9lXOB8PnOfH3OP2ai8xg_1788779853 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7181819540DE; Mon, 7 Sep 2026 11:17:33 +0000 (UTC) Received: from dmarchan.redhat.corp (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A49921955F0E; Mon, 7 Sep 2026 11:17:31 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Kishore Padmanabha , Ajit Khaparde , Andrew Rybchenko Subject: [PATCH v2 2/2] net/bnxt: fix MAC address removal Date: Mon, 7 Sep 2026 13:17:24 +0200 Message-ID: <20260907111724.3043887-2-david.marchand@redhat.com> In-Reply-To: <20260907111724.3043887-1-david.marchand@redhat.com> References: <20260904121651.2254684-1-david.marchand@redhat.com> <20260907111724.3043887-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RgURzHbgnKVJ0Enu5Q7gV4gAfrXK_cDRVGFo9J_Cxdc_1788779853 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MAC addresses removal was tied with VMDq pools even when not used. So if VMDq is not enabled, no address would be ever removed. Fixes: 9de506a6c781 ("ethdev: skip VMDq pools unless configured") Signed-off-by: David Marchand --- I could not test the change as I don't have this NIC. Probably worth squashing in 9de506a6c781 before pulling to main --- drivers/net/bnxt/bnxt_ethdev.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index c6f566c214..d37e2d16c9 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2019,14 +2019,21 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev, uint32_t index) { struct bnxt *bp = eth_dev->data->dev_private; - uint64_t pool_mask = eth_dev->data->mac_pool_sel[index]; + uint64_t pool_mask; struct bnxt_vnic_info *vnic; struct bnxt_filter_info *filter, *temp_filter; uint32_t i; + bool vmdq; if (is_bnxt_in_error(bp)) return; + vmdq = (eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_VMDQ_FLAG) != 0; + if (!vmdq) + pool_mask = 1; + else + pool_mask = eth_dev->data->mac_pool_sel[index]; + /* * Loop through all VNICs from the specified filter flow pools to * remove the corresponding MAC addr filter @@ -4540,6 +4547,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp) uint64_t pool_mask; uint32_t pool = 0; uint32_t i; + bool vmdq; int rc; if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) @@ -4549,6 +4557,8 @@ static int bnxt_restore_mac_filters(struct bnxt *bp) if (rc) return rc; + vmdq = (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_VMDQ_FLAG) != 0; + /* replay MAC address configuration */ for (i = 1; i < dev_info.max_mac_addrs; i++) { addr = &dev->data->mac_addrs[i]; @@ -4558,7 +4568,10 @@ static int bnxt_restore_mac_filters(struct bnxt *bp) continue; pool = 0; - pool_mask = dev->data->mac_pool_sel[i]; + if (!vmdq) + pool_mask = 1; + else + pool_mask = dev->data->mac_pool_sel[i]; do { if (pool_mask & 1ULL) { -- 2.54.0