From: Stephen Hemminger <stephen@networkplumber.org>
To: <kirankumark@marvell.com>
Cc: Aman Singh <aman.deep.singh@intel.com>,
Ori Kam <orika@nvidia.com>,
Alexander Kozyrev <akozyrev@nvidia.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Olga Shern <olgas@nvidia.com>, <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix error handling in flow API commands
Date: Mon, 7 Sep 2026 11:24:50 -0700 [thread overview]
Message-ID: <20260907112450.372f13a8@phoenix.local> (raw)
In-Reply-To: <20260907034831.791724-1-kirankumark@marvell.com>
On Mon, 7 Sep 2026 09:18:31 +0530
<kirankumark@marvell.com> wrote:
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> Fix two robustness issues in the flow API command paths:
>
> - port_flow_configure() committed the new queue attributes and job list
> before rte_flow_configure() succeeded, leaving the port state
> inconsistent on failure. Build the job list locally, free it on error,
> and update the port only after configure succeeds.
>
> - port_flow_create() and port_queue_flow_create() indexed ports[port_id]
> without validating the port id. Add an rte_eth_dev_is_valid_port()
> check before accessing the array.
>
> Fixes: 9ad3a41ab2a1 ("app/testpmd: add flow engine configuration")
> Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")
> Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> ---
Applied to next-net
prev parent reply other threads:[~2026-09-07 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 3:48 [PATCH] app/testpmd: fix error handling in flow API commands kirankumark
2026-09-07 18:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907112450.372f13a8@phoenix.local \
--to=stephen@networkplumber.org \
--cc=adrien.mazarguil@6wind.com \
--cc=akozyrev@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=kirankumark@marvell.com \
--cc=olgas@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox