From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org, hkalra@marvell.com
Subject: [RFC v3 0/5] Interrupts API update
Date: Mon, 7 Sep 2026 14:13:43 +0200 [thread overview]
Message-ID: <20260907121348.3049808-1-david.marchand@redhat.com> (raw)
This series is a simple cleanup to have a simpler helper that close all
FD reference in an interrupt handle.
It helped catch one small FD leak in FreeBSD EAL.
This should make life (a bit) easier on driver side and help limit FD
leaks.
--
David Marchand
Changes since RFC v2:
- added unit test for the new API,
- caught some FD leak by code review,
- split patch 3 from v2 in two, and added one debug check (see patch 5),
Changes since RFC v1:
- squashed FreeBSD PCI change,
- updated interrupt unit test,
David Marchand (5):
vdpa/mlx5: fix check on err interrupt FD
eal/freebsd: fix a FD leak in the alarm subsystem
interrupts: mark file descriptors invalid on allocation
interrupts: close interrupt FDs
interrupts: warn on leaked file descriptors
app/test/test_interrupts.c | 89 ++++++++++++++++++-
doc/guides/rel_notes/release_26_11.rst | 7 ++
drivers/bus/cdx/cdx_vfio.c | 16 ++--
drivers/bus/pci/bsd/pci.c | 7 +-
drivers/bus/pci/linux/pci_uio.c | 15 +---
drivers/bus/pci/linux/pci_vfio.c | 29 ++----
drivers/bus/pci/pci_common_uio.c | 18 +---
drivers/bus/vmbus/linux/vmbus_uio.c | 13 +--
drivers/bus/vmbus/vmbus_common_uio.c | 17 +---
drivers/common/cnxk/roc_platform.h | 2 +
drivers/common/mlx5/linux/mlx5_common_os.c | 6 +-
drivers/net/failsafe/failsafe.c | 3 -
drivers/net/mana/mana.c | 5 +-
drivers/net/memif/memif_socket.c | 13 +--
drivers/net/memif/rte_eth_memif.c | 6 --
drivers/net/mlx4/mlx4.c | 3 -
drivers/net/mlx4/mlx4_intr.c | 1 +
drivers/net/sxe2/sxe2_irq.c | 5 +-
drivers/net/tap/rte_eth_tap.c | 2 +-
.../net/virtio/virtio_user/virtio_user_dev.c | 2 +
drivers/raw/cnxk_gpio/cnxk_gpio.c | 3 +
drivers/vdpa/mlx5/mlx5_vdpa_event.c | 6 +-
drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 1 +
lib/eal/common/eal_common_interrupts.c | 35 ++++++++
lib/eal/freebsd/eal_alarm.c | 8 +-
lib/eal/include/rte_interrupts.h | 29 ++++++
lib/eal/linux/eal_dev.c | 9 +-
27 files changed, 211 insertions(+), 139 deletions(-)
--
2.54.0
next reply other threads:[~2026-09-07 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 12:13 David Marchand [this message]
2026-09-07 12:13 ` [RFC v3 1/5] vdpa/mlx5: fix check on err interrupt FD David Marchand
2026-09-07 12:13 ` [RFC v3 2/5] eal/freebsd: fix a FD leak in the alarm subsystem David Marchand
2026-09-07 12:35 ` Bruce Richardson
2026-09-07 12:47 ` David Marchand
2026-09-07 12:13 ` [RFC v3 3/5] interrupts: mark file descriptors invalid on allocation David Marchand
2026-09-07 12:13 ` [RFC v3 4/5] interrupts: close interrupt FDs David Marchand
2026-09-07 12:13 ` [RFC v3 5/5] interrupts: warn on leaked file descriptors David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907121348.3049808-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox