From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org
Subject: [PATCH] usertools/telemetry-watcher: fix hang on startup
Date: Wed, 9 Sep 2026 15:46:31 +0100 [thread overview]
Message-ID: <20260909144631.1122673-1-bruce.richardson@intel.com> (raw)
Commit cbfdffb1083d ("usertools/telemetry: load aliases from config
directory") added an extra printed output line to startup of the
dpdk-telemetry script when an alias file was loaded. This confuses the
wrapper script dpdk-telemetry-watcher, causing it to hang on startup.
Only print out the message when script is run interactively.
Fixes: cbfdffb1083d ("usertools/telemetry: load aliases from config directory")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
usertools/dpdk-telemetry.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py
index e575f269cb..b4dd789143 100755
--- a/usertools/dpdk-telemetry.py
+++ b/usertools/dpdk-telemetry.py
@@ -98,7 +98,9 @@ def load_aliases(alias_path=None):
except OSError as e:
print("Warning: failed to read {}: {}".format(alias_path, e), file=sys.stderr)
- print("Loaded {} aliases from {}".format(len(aliases), alias_path))
+ # only print this informational message in interactive mode
+ if os.isatty(sys.stdin.fileno()):
+ print("Loaded {} aliases from {}".format(len(aliases), alias_path))
return aliases
--
2.53.0
reply other threads:[~2026-09-09 14:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909144631.1122673-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox