From: Maxime Leroy <maxime@leroys.fr>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, anatoly.burakov@intel.com,
sivaprasad.tummala@amd.com, Maxime Leroy <maxime@leroys.fr>
Subject: [PATCH v2 1/6] examples/l3fwd-power: factor out Rx interrupt sleep path
Date: Wed, 9 Sep 2026 17:04:44 +0200 [thread overview]
Message-ID: <20260909150449.856295-2-maxime@leroys.fr> (raw)
In-Reply-To: <20260909150449.856295-1-maxime@leroys.fr>
The interrupt and legacy main loops carry an identical block that arms
the Rx queue interrupts of the lcore, sleeps until one triggers and
disarms them again. Move it to a helper so the following fixes touch a
single place.
No functional change.
Signed-off-by: Maxime Leroy <maxime@leroys.fr>
---
examples/l3fwd-power/main.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 705cab8f2d..764899217c 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -910,6 +910,14 @@ static int event_register(struct lcore_conf *qconf)
return 0;
}
+static void
+rx_interrupt_wait(struct lcore_conf *qconf)
+{
+ turn_on_off_intr(qconf, 1);
+ sleep_until_rx_interrupt(qconf->n_rx_queue, rte_lcore_id());
+ turn_on_off_intr(qconf, 0);
+}
+
/* Main processing loop. 8< */
static int main_intr_loop(__rte_unused void *dummy)
{
@@ -1054,11 +1062,7 @@ static int main_intr_loop(__rte_unused void *dummy)
else {
/* suspend until rx interrupt triggers */
if (intr_en) {
- turn_on_off_intr(qconf, 1);
- sleep_until_rx_interrupt(
- qconf->n_rx_queue,
- lcore_id);
- turn_on_off_intr(qconf, 0);
+ rx_interrupt_wait(qconf);
/**
* start receiving packets immediately
*/
@@ -1372,11 +1376,7 @@ main_legacy_loop(__rte_unused void *dummy)
else {
/* suspend until rx interrupt triggers */
if (intr_en) {
- turn_on_off_intr(qconf, 1);
- sleep_until_rx_interrupt(
- qconf->n_rx_queue,
- lcore_id);
- turn_on_off_intr(qconf, 0);
+ rx_interrupt_wait(qconf);
/**
* start receiving packets immediately
*/
--
2.43.0
next prev parent reply other threads:[~2026-09-09 15:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 8:00 [PATCH 0/6] examples/l3fwd-power: fix Rx interrupt mode for shared FD PMDs Maxime Leroy
2026-07-20 8:00 ` [PATCH 1/6] examples/l3fwd-power: factor out Rx interrupt sleep path Maxime Leroy
2026-07-20 8:00 ` [PATCH 2/6] examples/l3fwd-power: check Rx interrupt enable errors Maxime Leroy
2026-07-20 8:00 ` [PATCH 3/6] examples/l3fwd-power: enable Rx interrupt before epoll add Maxime Leroy
2026-09-04 9:15 ` David Marchand
2026-07-20 8:00 ` [PATCH 4/6] examples/l3fwd-power: accept shared Rx interrupt FD Maxime Leroy
2026-07-20 8:00 ` [PATCH 5/6] examples/l3fwd-power: recheck Rx queues before sleeping Maxime Leroy
2026-09-04 9:20 ` David Marchand
2026-09-04 20:25 ` Maxime Leroy
2026-07-20 8:00 ` [PATCH 6/6] examples/l3fwd-power: block until Rx interrupt or exit Maxime Leroy
2026-08-25 8:07 ` [PATCH 0/6] examples/l3fwd-power: fix Rx interrupt mode for shared FD PMDs Maxime Leroy
2026-09-04 9:30 ` David Marchand
2026-09-04 21:10 ` Maxime Leroy
2026-09-09 15:04 ` [PATCH v2 " Maxime Leroy
2026-09-09 15:04 ` Maxime Leroy [this message]
2026-09-09 15:04 ` [PATCH v2 2/6] examples/l3fwd-power: check Rx interrupt enable errors Maxime Leroy
2026-09-09 15:04 ` [PATCH v2 3/6] examples/l3fwd-power: enable Rx interrupt before epoll add Maxime Leroy
2026-09-09 15:04 ` [PATCH v2 4/6] examples/l3fwd-power: accept shared Rx interrupt FD Maxime Leroy
2026-09-09 15:04 ` [PATCH v2 5/6] examples/l3fwd-power: recheck Rx queues before sleeping Maxime Leroy
2026-09-09 15:04 ` [PATCH v2 6/6] examples/l3fwd-power: block until Rx interrupt or exit Maxime Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909150449.856295-2-maxime@leroys.fr \
--to=maxime@leroys.fr \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=sivaprasad.tummala@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox