DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Novikov <naa@amicon.ru>
To: <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <naa@amicon.ru>, <rrv@amicon.ru>,
	<lvc-project@linuxtesting.org>, <stable@dpdk.org>
Subject: [PATCH] net/intel/common: avoid field pointer arithmetic
Date: Mon, 14 Sep 2026 13:04:33 +0300	[thread overview]
Message-ID: <20260914100433.53971-1-naa@amicon.ru> (raw)

The Rx rearm failure path assigns fake mbufs through rxp, but rxp is the
address of the mbuf field in a single software ring entry.

Use the software ring array for indexed access so pointer arithmetic is
done on struct ci_rx_entry instead of on the address of a field.

Fixes: 773cbaf2ad38 ("net/intel: avoid allocating from mempool directly")
Cc: stable@dpdk.org
Cc: bruce.richardson@intel.com

Signed-off-by: Artem Novikov <naa@amicon.ru>
---
 drivers/net/intel/common/rx_vec_x86.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/intel/common/rx_vec_x86.h b/drivers/net/intel/common/rx_vec_x86.h
index 8d497e7196..9670a21fa4 100644
--- a/drivers/net/intel/common/rx_vec_x86.h
+++ b/drivers/net/intel/common/rx_vec_x86.h
@@ -33,7 +33,7 @@ _ci_rxq_rearm_get_bufs(struct ci_rx_queue *rxq)
 			const __m128i zero = _mm_setzero_si128();
 
 			for (i = 0; i < CI_VPMD_DESCS_PER_LOOP; i++) {
-				rxp[i] = &rxq->fake_mbuf;
+				rxq->sw_ring[rxq->rxrearm_start + i].mbuf = &rxq->fake_mbuf;
 				_mm_store_si128(RTE_CAST_PTR(__m128i *, &rxdp[i]), zero);
 			}
 		}
-- 
2.43.0


             reply	other threads:[~2026-09-14 11:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 10:04 Artem Novikov [this message]
2026-09-14 11:23 ` [PATCH] net/intel/common: avoid field pointer arithmetic Bruce Richardson
2026-10-05 15:22   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914100433.53971-1-naa@amicon.ru \
    --to=naa@amicon.ru \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=rrv@amicon.ru \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox