DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Novikov <naa@amicon.ru>
To: <bruce.richardson@intel.com>, <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, <lvc-project@linuxtesting.org>, <naa@amicon.ru>,
	<rrv@amicon.ru>, <ting.xu@intel.com>, <stable@dpdk.org>
Subject: [PATCH] net/ice: ignore WRED parameters for tail drop in DCF
Date: Mon, 14 Sep 2026 13:10:03 +0300	[thread overview]
Message-ID: <20260914101003.55635-1-naa@amicon.ru> (raw)

The traffic management API defines leaf WRED parameters as valid only
when the congestion management mode is WRED. DCF only accepts tail drop,
but still validates the WRED profile and shared contexts. A tail-drop
node with a zero-initialized, unused WRED profile is therefore rejected
unless the application supplies RTE_TM_WRED_PROFILE_ID_NONE.

Compare the mode explicitly against RTE_TM_CMAN_TAIL_DROP and reject
unsupported modes with a precise error message. Do not validate WRED
parameters for the supported tail-drop mode.

Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
Cc: stable@dpdk.org

Signed-off-by: Artem Novikov <naa@amicon.ru>
---
 drivers/net/intel/ice/ice_dcf_sched.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/drivers/net/intel/ice/ice_dcf_sched.c b/drivers/net/intel/ice/ice_dcf_sched.c
index 795b6e683df55d447163e3f447b4e5b6f17552cd..5b5a90b37afec90619633539749c93993bc42616 100644
--- a/drivers/net/intel/ice/ice_dcf_sched.c
+++ b/drivers/net/intel/ice/ice_dcf_sched.c
@@ -200,28 +200,9 @@ ice_dcf_node_param_check(struct ice_dcf_hw *hw, uint32_t node_id,
 	}
 
 	/* for leaf node */
-	if (params->leaf.cman) {
+	if (params->leaf.cman != RTE_TM_CMAN_TAIL_DROP) {
 		error->type = RTE_TM_ERROR_TYPE_NODE_PARAMS_CMAN;
-		error->message = "Congestion management not supported";
-		return -EINVAL;
-	}
-	if (params->leaf.wred.wred_profile_id !=
-	    RTE_TM_WRED_PROFILE_ID_NONE) {
-		error->type =
-			RTE_TM_ERROR_TYPE_NODE_PARAMS_WRED_PROFILE_ID;
-		error->message = "WRED not supported";
-		return -EINVAL;
-	}
-	if (params->leaf.wred.shared_wred_context_id) {
-		error->type =
-			RTE_TM_ERROR_TYPE_NODE_PARAMS_SHARED_WRED_CONTEXT_ID;
-		error->message = "WRED not supported";
-		return -EINVAL;
-	}
-	if (params->leaf.wred.n_shared_wred_contexts) {
-		error->type =
-			RTE_TM_ERROR_TYPE_NODE_PARAMS_N_SHARED_WRED_CONTEXTS;
-		error->message = "WRED not supported";
+		error->message = "Only tail drop is supported";
 		return -EINVAL;
 	}
 
-- 
2.43.0

             reply	other threads:[~2026-09-14 11:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 10:10 Artem Novikov [this message]
2026-10-05 15:34 ` [PATCH] net/ice: ignore WRED parameters for tail drop in DCF Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914101003.55635-1-naa@amicon.ru \
    --to=naa@amicon.ru \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=rrv@amicon.ru \
    --cc=stable@dpdk.org \
    --cc=ting.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox