From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org
Subject: [PATCH 2/2] net/cpfl: fix overflow on store of single-queue settings
Date: Mon, 14 Sep 2026 17:22:34 +0100 [thread overview]
Message-ID: <20260914162234.4058977-2-bruce.richardson@intel.com> (raw)
In-Reply-To: <20260914162234.4058977-1-bruce.richardson@intel.com>
The Rx and Tx single queue settings in cpfl driver are both boolean
values, but the parse_bool function writes to them as int. This causes
an extra 3 bytes to be written beyond the variable itself.
Fix by changing store type to bool.
Bugzilla ID: 2042
Fixes: 2d823ecd671c ("net/cpfl: support device initialization")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
===
Note: this fix is superceded by the kvargs numeric args patchset [1].
However, that patchset relies on new kvargs features unlikely to be
backported, so this standalone fix is useful for backporting or if the
whole other set doesn't make the 26.11 release.
[1] https://patches.dpdk.org/project/dpdk/list/?series=39247
---
drivers/net/intel/cpfl/cpfl_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.c b/drivers/net/intel/cpfl/cpfl_ethdev.c
index 4315adb68c..b1b7637f48 100644
--- a/drivers/net/intel/cpfl/cpfl_ethdev.c
+++ b/drivers/net/intel/cpfl/cpfl_ethdev.c
@@ -1448,7 +1448,7 @@ parse_vport(const char *key, const char *value, void *args)
static int
parse_bool(const char *key, const char *value, void *args)
{
- int *i = args;
+ bool *i = args;
char *end;
int num;
@@ -1462,7 +1462,7 @@ parse_bool(const char *key, const char *value, void *args)
return -EINVAL;
}
- *i = num;
+ *i = (num == 1);
return 0;
}
--
2.53.0
next prev parent reply other threads:[~2026-09-14 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 17:38 [DPDK/ethdev Bug 2042] net/intel/idpf and net/intel/cpfl: four byte store into a bool bugzilla
2026-09-14 16:22 ` [PATCH 1/2] net/idpf: fix overflow on store of single-queue settings Bruce Richardson
2026-09-14 16:22 ` Bruce Richardson [this message]
2026-09-15 10:42 ` [PATCH 2/2] net/cpfl: " Shetty, Praveen
2026-09-15 10:41 ` [PATCH 1/2] net/idpf: " Shetty, Praveen
2026-09-18 14:47 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914162234.4058977-2-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox