From: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
To: dev@dpdk.org
Cc: kishore.padmanabha@broadcom.com,
Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>,
stable@dpdk.org, Dakota Sicher <dakota.sicher@broadcom.com>
Subject: [PATCH] net/bnxt: fix flow create segfault
Date: Thu, 17 Sep 2026 21:27:01 -0600 [thread overview]
Message-ID: <20260918032701.763364-1-Mohammad-Shuab.Siddique@broadcom.com> (raw)
From: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
When creating a flow that requires a destination queue but none is
specified in the flow create command, find_matching_vnic() returns
NULL and the code falls through to insert the new filter into
vnic->filter, dereferencing the NULL vnic and causing a segfault.
Check for a NULL vnic and reject the flow create with a clear error
instead of crashing.
Fixes: 59119d49529e ("net/bnxt: fix flow create when RSS is disabled")
Cc: stable@dpdk.org
Signed-off-by: Dakota Sicher <dakota.sicher@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
---
drivers/net/bnxt/bnxt_flow.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index a2e590540b..0a2899fbbd 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -2148,6 +2148,13 @@ bnxt_flow_create(struct rte_eth_dev *dev,
}
vnic = find_matching_vnic(bp, filter);
+ if (!vnic) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
+ "Missing destination action for flow.");
+ bnxt_clear_one_vnic_filter(bp, filter);
+ goto free_filter;
+ }
done:
if (!ret || update_flow) {
flow->filter = filter;
--
2.47.3
next reply other threads:[~2026-09-18 3:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 3:27 Mohammad Shuab Siddique [this message]
2026-09-21 2:18 ` [PATCH v2] net/bnxt: fix flow create segfault Mohammad Shuab Siddique
2026-09-21 15:46 ` Stephen Hemminger
2026-09-29 0:23 ` [PATCH v3] " Mohammad Shuab Siddique
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918032701.763364-1-Mohammad-Shuab.Siddique@broadcom.com \
--to=mohammad-shuab.siddique@broadcom.com \
--cc=dakota.sicher@broadcom.com \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox