DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Raghavendra Ningoji <raghavendra.ningoji@amd.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, Jingjing Wu <jingjing.wu@intel.com>,
	Selwin Sebastian <Selwin.Sebastian@amd.com>,
	Bhagyada Modali <bhagyada.modali@amd.com>,
	"Thomas Monjalon" <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH v1 3/3] doc: add AMD NTB support
Date: Mon, 28 Sep 2026 16:17:14 +0530	[thread overview]
Message-ID: <20260928104714.2373250-1-raghavendra.ningoji@amd.com> (raw)
In-Reply-To: <arZSCR-GL1jq3iqM@bricha3-mobl1.ger.corp.intel.com>

On Fri, Sep 25, 2026 at 10:50:49AM +0000, Bruce Richardson wrote:
> This documentation should be squashed into the prevous patch adding the
> support. See also one additional comment below.

Done - in v2 the documentation, release note and MAINTAINERS update are
squashed into the AMD driver patch, so the series is now 2 patches.

> > +The AMD NTB hardware exposes two memory windows (BAR23 and BAR45), 16
> > +doorbells and a single shared 16-register scratchpad bank. The scratchpad
> > +bank is split into two disjoint 8-register sets, one owned by each side, so
> > +the driver uses a packed handshake layout that fits within 8 registers.
> > +
>
> The documentation needs an update on the alignment requirements and
> handling - either the need for the new alignment API if one is added as I
> suggested, or else details on how the app needs to handle it itself (which
> is less preferable).

Added. v2 adds the new rte_pmd_ntb_get_mem_align() API (as you
suggested), and the guide now documents the outbound translation window
constraint and instructs applications to reserve each memory window
memzone with the alignment returned by that API, pointing at the
ntb_fwd example as the reference usage.

Thanks,
Raghavendra

  reply	other threads:[~2026-09-28 10:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 14:06 [PATCH v1 0/3] raw/ntb: add AMD NTB support Raghavendra Ningoji
2026-08-23 14:06 ` [PATCH v1 1/3] raw/ntb: generalize framework for multiple vendors Raghavendra Ningoji
2026-09-18 15:06   ` Bruce Richardson
2026-09-21  6:13     ` Raghavendra Ningoji
2026-08-23 14:06 ` [PATCH v1 2/3] raw/ntb: add AMD NTB support Raghavendra Ningoji
2026-09-25 10:22   ` Bruce Richardson
2026-09-28 10:46     ` Raghavendra Ningoji
2026-08-23 14:06 ` [PATCH v1 3/3] doc: " Raghavendra Ningoji
2026-09-25 10:50   ` Bruce Richardson
2026-09-28 10:47     ` Raghavendra Ningoji [this message]
2026-09-11 18:30 ` [PATCH v1 0/3] raw/ntb: " Raghavendra Ningoji
2026-09-16 11:29 ` David Marchand
2026-09-25  9:17   ` [v1,0/3] " Bhagyada Modali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928104714.2373250-1-raghavendra.ningoji@amd.com \
    --to=raghavendra.ningoji@amd.com \
    --cc=Selwin.Sebastian@amd.com \
    --cc=bhagyada.modali@amd.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jingjing.wu@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox